Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async PV for workspace: enabling feature (toggle) #15960

Closed
Tracked by #15384
benoitf opened this issue Feb 7, 2020 · 7 comments
Closed
Tracked by #15384

Async PV for workspace: enabling feature (toggle) #15960

benoitf opened this issue Feb 7, 2020 · 7 comments
Assignees
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Feb 7, 2020

Enable feature

subtask of #15384

By default workspaces are always using a PVC (or emptyDir for ephemeral workspaces)

In the same approach used for ephemeral we could add a new attribute of the workspace definition

attributes:
  asyncPersist: true

attribute name can be changed.

By using that toggle, it means that a new container will be added to the workspace/pod which will do the sync. And of course, it will use emptyDir as well

It will allow to have this feature enabled per workspace to try how it works and be able to compare, etc.

@benoitf benoitf added kind/task Internal things, technical debt, and to-do tasks to be performed. area/dev-experience labels Feb 7, 2020
@benoitf benoitf added this to the Backlog - Hosted Che milestone Feb 7, 2020
@benoitf benoitf changed the title Async PVC for workspace: enabling feature (toggle) Async PV for workspace: enabling feature (toggle) Feb 7, 2020
@vparfonov vparfonov self-assigned this May 4, 2020
@ibuziuk ibuziuk modified the milestones: Backlog - Hosted Che, 7.14 May 13, 2020
@ibuziuk
Copy link
Member

ibuziuk commented May 29, 2020

Proposed UD design - an experimental checkbox that could be enabled only when temporary storage toggle is on:

image

@ibuziuk
Copy link
Member

ibuziuk commented May 29, 2020

cc @beaumorley any comments ^

@benoitf
Copy link
Contributor Author

benoitf commented May 29, 2020

if you check async but you disable temporary storage IMHO it doesn't work as well so this is why I was thinking of a dropdown

@ibuziuk
Copy link
Member

ibuziuk commented May 29, 2020

@benoitf my idea was that checkbox can only be enabled (maybe even visible) only if the temporary toggle is on

@ibuziuk
Copy link
Member

ibuziuk commented May 29, 2020

After the discussion during prio call it looks like it would be better to opt for dropdown:
image

@vparfonov
Copy link
Contributor

Demo: https://youtu.be/EU_4M1ZHELw

@ibuziuk ibuziuk modified the milestones: 7.15, 7.16 Jun 24, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Jul 15, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants