Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework switcher for ephemeral mode to the dropdown with storage types #58

Merged
merged 23 commits into from
Jul 27, 2020
Merged

Rework switcher for ephemeral mode to the dropdown with storage types #58

merged 23 commits into from
Jul 27, 2020

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Jun 15, 2020 •
edited by akurinnoy
Loading

What does this PR do?

Replace Temporary Storage switcher

with Storage Type selector

In case Ephemeral will be added:

attributes:
  persistVolumes: 'false'

In case Asynchronous:

attributes:
  persistVolumes: 'false'
  asyncPersist: 'true'

If Persistent attribute not required

How it looks like:
https://youtu.be/EU_4M1ZHELw

What issues does this PR fix or reference?

Fixes eclipse-che/che#17230

The Che Server side is done in eclipse-che/che#15960

Release Notes

Docs PR

@vparfonov vparfonov changed the title Rework switcher fro ephemeral mode to the dropdown with storage types WIP: Rework switcher fro ephemeral mode to the dropdown with storage types Jun 16, 2020
@vparfonov vparfonov marked this pull request as ready for review June 16, 2020 15:06
@vparfonov vparfonov marked this pull request as draft June 16, 2020 15:11
@vparfonov vparfonov changed the title WIP: Rework switcher fro ephemeral mode to the dropdown with storage types Rework switcher fro ephemeral mode to the dropdown with storage types Jun 16, 2020
@vparfonov
Add style
656d81d 
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov vparfonov marked this pull request as ready for review June 17, 2020 08:01
vparfonov added 2 commits June 17, 2020 11:09
@vparfonov
Code cleanup
8ebba64 
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov
Remove package-lock.json
525a0c9 
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov vparfonov changed the title Rework switcher fro ephemeral mode to the dropdown with storage types Rework switcher for ephemeral mode to the dropdown with storage types Jun 17, 2020
@vparfonov
Fix typo and formating
454a4f5 
Signed-off-by: Vitalii Parfonov <[email protected]>
@vparfonov vparfonov mentioned this pull request Jun 17, 2020
Closed
22 tasks
@sleshchenko sleshchenko mentioned this pull request Jun 24, 2020
Closed
@akurinnoy akurinnoy marked this pull request as draft July 8, 2020 07:19
akurinnoy added 6 commits July 8, 2020 15:15
@akurinnoy
added patternfly popover component
c55da76 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
fixed accidentally changed condition
76e4db3 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
updated gulp task
8394be0 
Fix proxying requests to API in case if target ends with "/"

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
added Patternfly modal box component
12e7348 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
updated temporary-storage-row component
f7433f1 
Show available options of storage type as a select instead of switch.

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
renamed component
1c2f251 
temporary-storage-row => storage-type-row

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@sleshchenko sleshchenko added this to the 7.17 milestone Jul 13, 2020
akurinnoy added 2 commits July 14, 2020 10:25
@akurinnoy
reworked overview tab
44e1f26 
replace "select" with "che-select"

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy
fixup! updated temporary-storage-row component
f03bbe1
@akurinnoy akurinnoy force-pushed the toggelStorageType branch from 89ba3fd to 11d0fc7 Compare July 14, 2020 07:35
@akurinnoy
cleaned up
cb97575 
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy force-pushed the toggelStorageType branch from 11d0fc7 to cb97575 Compare July 14, 2020 07:39
@akurinnoy
Copy link
Contributor

akurinnoy commented Jul 14, 2020 •
edited
Loading

Screenshots

Get Started -> Custom Workspace Tab Screenshot 2020-07-14 at 10 55 45 Screenshot 2020-07-14 at 10 55 50 Screenshot 2020-07-14 at 10 55 56
Workspace Details -> Overview Tab Screenshot 2020-07-14 at 10 56 09 Screenshot 2020-07-14 at 10 56 15 Screenshot 2020-07-14 at 10 56 41

@akurinnoy akurinnoy marked this pull request as ready for review July 23, 2020 13:44
@olexii4
Copy link
Contributor

olexii4 commented Jul 24, 2020 •
edited
Loading

It didn't work for me
Screenshot from 2020-07-24 15-37-46
Screenshot from 2020-07-24 15-38-52

'Learn more about storage types' should be aligned

@akurinnoy
Copy link
Contributor

@olexii4 it's expected because openshift.io doesn't support this feature yet. Try to test it using nightly Che as a target.

@olexii4
Copy link
Contributor

olexii4 commented Jul 24, 2020

LGTM

@olexii4
Copy link
Contributor

olexii4 commented Jul 27, 2020

Screenshot from 2020-07-27 09-40-42
Screenshot from 2020-07-27 09-41-36

@olexii4
Copy link
Contributor

olexii4 commented Jul 27, 2020

Tested with v7.17.0

@akurinnoy akurinnoy merged commit 1e63efa into master Jul 27, 2020
@akurinnoy akurinnoy deleted the toggelStorageType branch July 27, 2020 06:47
akurinnoy pushed a commit that referenced this pull request Jan 13, 2021
@olexii4
Improve license-tool scripts (#58)
f2d40d9 
* improve license-tool scripts

Signed-off-by: Oleksii Orel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleshchenko sleshchenko sleshchenko left review comments

@akurinnoy akurinnoy akurinnoy approved these changes

@olexii4 olexii4 olexii4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.17
Development

Successfully merging this pull request may close these issues.

Finalize Storage Type switcher
4 participants
@vparfonov @akurinnoy @olexii4 @sleshchenko