This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Added external libraries feature #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
benoitf
suggested changes
Aug 2, 2018
che-theia-java-extension/src/browser/che-theia-java-frontend-module.ts
Outdated
Show resolved
Hide resolved
che-theia-java-extension/src/browser/external-libraries/external-libraries-model.ts
Outdated
Show resolved
Hide resolved
JPinkney
force-pushed
the
test2
branch
3 times, most recently
from
d5b919e to
634a95b
Compare
19 tasks
benoitf
reviewed
Oct 1, 2018
che-theia-java-extension/src/browser/che-theia-java-frontend-module.ts
Outdated
Show resolved
Hide resolved
che-theia-java-extension/src/browser/libraries/chelib-resource-provider.ts
Outdated
Show resolved
Hide resolved
che-theia-java-extension/src/browser/libraries/chelib-resource-provider.ts
Outdated
Show resolved
Hide resolved
che-theia-java-extension/src/browser/libraries/chelib-resource-provider.ts
Outdated
Show resolved
Hide resolved
benoitf
approved these changes
Oct 1, 2018
15 tasks
15 tasks
Signed-off-by: jpinkney <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this PR currently you have to open a java file before trying to open external libraries. I will create a PR on Theia side that allows language contributions to start when a certain file(s) are in the workspace and then provide the fix to theia java contribution.
Signed-off-by: jpinkney [email protected]