Batching v2 #765
Merged
Batching v2 #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'internal', 'dependencies', 'bug', 'documentation', 'new feature', 'enhancement', 'breaking-change'} |
sashacmc
approved these changes
Oct 28, 2024
jean-roland
added a commit
to jean-roland/zenoh-pico
that referenced
this pull request
Nov 13, 2024
* feat: switch id empty/check to static inline * feat: use batch count instead of batch vec * refactor: batch don't copy messages * feat: rename batch api * feat: group common transport fields * feat: use common struct in tx functions * feat: rename multicast tx functions * fix: unreachable * refactor: fuse unicast and multicast tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batching mechanism doesn't copy the messages and fills buffer and flush buffer as needed. Buffer is flushed one last time when batching is deactivated.
Refactor the transport tx layer as unicast and multicast were virtually the same.