Implement error reply support #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
add_reply_err
branch
3 times, most recently
from
1de96ec to
6dac662
Compare
jean-roland
reviewed
Jul 10, 2024
| @@ -65,7 +74,7 @@ int main(int argc, char **argv) { | |||
| int n = 0; | |||
|
|
|||
| int opt; | |||
| while ((opt = getopt(argc, argv, "k:e:m:v:l:n:d")) != -1) { | |||
| while ((opt = getopt(argc, argv, "k:e:m:v:l:n:df")) != -1) { | |||
There was a problem hiding this comment.
No, ":" means that option value expected
https://www.man7.org/linux/man-pages/man3/getopt.3.html
| // FIXME: The support for reply errors will come in the next release. | ||
| return true; | ||
| } | ||
| _Bool z_reply_is_ok(const z_loaned_reply_t *reply) { return reply->_tag != _Z_REPLY_TAG_ERROR; } |
There was a problem hiding this comment.
With this modification, this PR probably closes #345 as well.
jean-roland
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement error reply send and receive support
Add API methods:
Update z_get to receive error reply
Update z_queryable with the option to send error
Mark z_reply_tag_t as private
Closes:
#460
#463