Rework owned sample #391
Merged
Rework owned sample #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashacmc
force-pushed
the
protocol_pull_sample_rework
branch
from
9159306 to
2bf7891
Compare
sashacmc
force-pushed
the
protocol_pull_sample_rework
branch
from
a058ec5 to
0fadf18
Compare
sashacmc
force-pushed
the
protocol_pull_sample_rework
branch
from
443bc85 to
afb24bf
Compare
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
jean-roland
reviewed
Apr 5, 2024
| } | ||
| return res; | ||
| // -- Sample | ||
| void _z_owned_sample_move(z_owned_sample_t *dst, const z_owned_sample_t *src) { |
There was a problem hiding this comment.
Isn't that a copy more than a move?
There was a problem hiding this comment.
We're just copying the pointer, so we're essentially move ownership of the data.
src/collections/fifo_mt.c
Outdated
| } | ||
|
|
||
| #if Z_FEATURE_MULTI_THREAD == 1 | ||
| res = zp_mutex_init(&fifo->_mutex); |
There was a problem hiding this comment.
all the zp_* system calls are deprecated, you should use z_mutex & z_condvar instead
There was a problem hiding this comment.
I don't see them in this branch :(
jean-roland
reviewed
Apr 5, 2024
| if (res) { | ||
| return res; | ||
| } | ||
| _Z_RETURN_IF_ERR(zp_mutex_init(&fifo->_mutex)) |
There was a problem hiding this comment.
Still needs to replace the deprecrated systems calls: https://github.com/eclipse-zenoh/zenoh-pico/blob/main/src/deprecated/platform.c
There was a problem hiding this comment.
I suggest to ago ahed with this PR and we then update #394. @jean-roland what do you think?
jean-roland
approved these changes
Apr 5, 2024
Mallets
reviewed
Apr 5, 2024
Mallets
approved these changes
Apr 5, 2024
Mallets
added a commit
that referenced
this pull request
Apr 8, 2024
* Remove ACK message * Cleanup pull and subscriber * Remove Put/Del from ResponseBody * Cleanup flags * Comment unusued variables in pull examples * Fix alignment test * Add ring to collections * Pull examples. Fake z_owned_sample_t * Channels initial commit * Added channel macros * Rename sample_ring to sample_channel_ring * Add fifo and lifo collections * Moved utils to handlers. Added FIFO handlers. Add z_sub_channel. * Improve pull example * Fix return in void functions * Fix prototype * Fix newline at end of the file * Fix windows examples target * Remove unexisting windows z_sub_channel from CMAke * Remove unexisting unix c99 z_sub_channel from CMAke * Rework owned sample (#391) * Owned sample draft * Continue owned sample implementation * [skip ci] Channel macro draft * [skip ci] Fix element copy * Add fifo channel * Add channel clean up and some refactoring/fixes * Syntax fix * Refactoring, cleanup * Rename elem copy to move * Improve naming * TODO resolving * Add channel tests * Apply review feedback * Add encoding copy --------- Co-authored-by: Alexander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework owned sample processing for pull and sub_channel:
fifo_mtandring_mt_Z_CHANNEL_DEFINEz_owned_sample_t:z_owned_closure_owned_sample_tz_owned_sample_ring_channel_tandz_owned_sample_fifo_channel_tchannels(NB: channels for queries and replies will be provided in the separate PR)