Fix ping-pong examples (#226) (#227) #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imstevenpmwork can you double check if it fixes both of your issues? |
|
Hello Carlos, thanks for the quick reply. I tested this PR with the same system and I confirm both of the problems are solved. Code changes look good too to me |
p-avital
suggested changes
Jul 6, 2023
| @@ -79,8 +100,8 @@ int main(int argc, char** argv) { | |||
| _z_mutex_unlock(&mutex); | |||
| z_free(results); | |||
| z_free(data); | |||
| z_drop(z_move(sub)); | |||
| z_drop(z_move(pub)); | |||
There was a problem hiding this comment.
z_drop should be favored in c11 examples
examples/unix/c11/z_pong.c
Outdated
| while (getchar() != 'q') { | ||
| } | ||
| z_drop(z_move(sub)); | ||
|
|
||
| z_undeclare_subscriber(z_move(sub)); |
| z_undeclare_subscriber(z_move(sub)); | ||
| z_undeclare_publisher(z_move(pub)); | ||
| z_close(z_move(session)); | ||
| z_undeclare_subscriber(z_subscriber_move(&sub)); |
There was a problem hiding this comment.
don't switch this to z_drop, it's a c99 example (leaving the comment just in case)
examples/windows/z_ping.c
Outdated
| @@ -77,8 +97,8 @@ int main(int argc, char** argv) { | |||
| _z_mutex_unlock(&mutex); | |||
| z_free(results); | |||
| z_free(data); | |||
| z_drop(z_move(sub)); | |||
| z_drop(z_move(pub)); | |||
| z_undeclare_publisher(z_move(pub)); | |||
examples/windows/z_pong.c
Outdated
| while (getchar() != 'q') { | ||
| } | ||
| z_drop(z_move(sub)); | ||
|
|
||
| z_undeclare_subscriber(z_move(sub)); |
p-avital
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #226 and #227