Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misuse the callback in z_info #602

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

YuanYuYuan
Copy link
Contributor

This PR has partially fixed #601. The remaining task is aligning the ZID order with the Rust side. Despite the same underlying[u8; 16], we display the ZID in LSB order in Rust. That's why we saw a mismatch (actually they are the reverse of each other).

  1. Modify the example z_info (and any other usages) to print ZID reversely.
  2. Provide a zid_to_string function to avoid any confusion.
  3. Change LSB order formatting in the uhlc crate.

@Mallets Mallets merged commit 853162c into eclipse-zenoh:dev/1.0.0 Aug 19, 2024
7 checks passed
@YuanYuYuan YuanYuYuan deleted the fix/z_info branch January 9, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants