Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z_publisher_set_* methods #429

Merged

Conversation

sashacmc
Copy link
Member

@sashacmc sashacmc commented Jun 7, 2024

  • z_publisher_set_congestion_control
  • z_publisher_set_priority
  • z_publisher_set_allowed_destination

@sashacmc sashacmc marked this pull request as ready for review June 7, 2024 11:35
src/publisher.rs Outdated Show resolved Hide resolved
@DenisBiryukov91
Copy link
Contributor

do we really need these apis, given that they can be set via options ? Also do we need corresponding getters ?

@sashacmc
Copy link
Member Author

sashacmc commented Jun 7, 2024

do we really need these apis, given that they can be set via options ? Also do we need corresponding getters ?

AFAIK, e.g. congestion_control we want to change "on fly"

@sashacmc sashacmc force-pushed the add_publication_set_methods branch from 1406c22 to 0685dd4 Compare June 7, 2024 14:19
@sashacmc sashacmc force-pushed the add_publication_set_methods branch from 0685dd4 to 19e2b12 Compare June 7, 2024 14:22
@milyin milyin merged commit 6c1df6c into eclipse-zenoh:dev/1.0.0 Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants