Avoid unnecessary lock on UI thread with no model listeners #3251

Avoid unnecessarily aquiring a lock on the UI thread if there are no model listeners in the Xtext document. Signed-off-by: Martin Jobst <[email protected]>
eclipse-xtext · Nov 27, 2024 · da7fed8 · da7fed8
1 parent 4eebe72
commit da7fed8
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/editor/model/XtextDocument.java b/org.eclipse.xtext.ui/src/org/eclipse/xtext/ui/editor/model/XtextDocument.java
@@ -563,6 +563,11 @@ protected <T> T internalReadOnly(IUnitOfWork<T, XtextResource> work, boolean isC
 		 *       changing while they run. To achieve this, we run the {@link IXtextModelListener}s on the UI thread.
 		 */
 		private void notifyModelListenersOnUiThread() {
+			synchronized (modelListeners) {
+				if (modelListeners.isEmpty()) {
+					return;
+				}
+			}
 			Display display = PlatformUI.getWorkbench().getDisplay();
 			if (Thread.currentThread() == display.getThread()) {
 				// We are already running on the display thread.  Run the listeners immediately.