-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize method for reading the files generated by the deployer #2094
Merged
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
baixinsui:feat/optimize_versions_init
Nov 12, 2024
Merged
Optimize method for reading the files generated by the deployer #2094
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
baixinsui:feat/optimize_versions_init
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
4 similar comments
LGTM |
LGTM |
LGTM |
LGTM |
baixinsui
force-pushed
the
feat/optimize_versions_init
branch
2 times, most recently
from
November 5, 2024 12:24
0022634
to
6ca3778
Compare
baixinsui
force-pushed
the
feat/optimize_versions_init
branch
15 times, most recently
from
November 11, 2024 09:15
9390a10
to
6a8f525
Compare
baixinsui
force-pushed
the
feat/optimize_versions_init
branch
6 times, most recently
from
November 12, 2024 11:35
a73ddb2
to
dc9ac5b
Compare
baixinsui
force-pushed
the
feat/optimize_versions_init
branch
from
November 12, 2024 11:40
dc9ac5b
to
895ad1c
Compare
swaroopar
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2068
Based on eclipse-xpanse/terraform-boot#162 and eclipse-xpanse/tofu-maker#79
Deploy service with scripts from git repo successfully:
Stored generated files only tfatate and tf.log not contains any scripts file from git repo.