Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize method for reading the files generated by the deployer #2094

Merged

Conversation

baixinsui
Copy link
Contributor

@baixinsui baixinsui commented Nov 5, 2024

Fixed #2068

Based on eclipse-xpanse/terraform-boot#162 and eclipse-xpanse/tofu-maker#79

Deploy service with scripts from git repo successfully:
image
Stored generated files only tfatate and tf.log not contains any scripts file from git repo.
image

@qigaoneng
Copy link

LGTM

4 similar comments
@Alice1319
Copy link
Contributor

LGTM

@profoundwu
Copy link

LGTM

@WangLiNaruto
Copy link
Contributor

LGTM

@yuanxiaojun987
Copy link

LGTM

@baixinsui baixinsui reopened this Nov 11, 2024
@baixinsui baixinsui force-pushed the feat/optimize_versions_init branch 6 times, most recently from a73ddb2 to dc9ac5b Compare November 12, 2024 11:35
@baixinsui baixinsui force-pushed the feat/optimize_versions_init branch from dc9ac5b to 895ad1c Compare November 12, 2024 11:40
Copy link
Contributor

@swaroopar swaroopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopar swaroopar merged commit deb7e4a into eclipse-xpanse:main Nov 12, 2024
3 checks passed
@baixinsui baixinsui deleted the feat/optimize_versions_init branch November 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change how we find the files generated by the deployer
7 participants