-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend terraform and opentofu local deployers to support multiple versions #1980
Merged
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
baixinsui:feat/deployer_with_version
Oct 11, 2024
Merged
extend terraform and opentofu local deployers to support multiple versions #1980
swaroopar
merged 1 commit into
eclipse-xpanse:main
from
baixinsui:feat/deployer_with_version
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baixinsui
force-pushed
the
feat/deployer_with_version
branch
from
September 26, 2024 12:37
dde31eb
to
511b1a0
Compare
baixinsui
force-pushed
the
feat/deployer_with_version
branch
from
September 26, 2024 12:41
511b1a0
to
2ab0974
Compare
...c/main/java/org/eclipse/xpanse/modules/deployment/deployers/DeployerToolVersionsFetcher.java
Outdated
Show resolved
Hide resolved
baixinsui
force-pushed
the
feat/deployer_with_version
branch
from
September 27, 2024 02:20
2ab0974
to
6c76afe
Compare
LGTM |
baixinsui
force-pushed
the
feat/deployer_with_version
branch
4 times, most recently
from
September 27, 2024 03:38
edfeb31
to
957cad2
Compare
swaroopar
requested changes
Sep 27, 2024
...c/main/java/org/eclipse/xpanse/modules/deployment/deployers/DeployerToolVersionsFetcher.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/xpanse/modules/deployment/deployers/DeployerToolVersionsFetcher.java
Outdated
Show resolved
Hide resolved
baixinsui
force-pushed
the
feat/deployer_with_version
branch
4 times, most recently
from
September 30, 2024 08:45
abdce01
to
2e80aca
Compare
baixinsui
force-pushed
the
feat/deployer_with_version
branch
9 times, most recently
from
October 10, 2024 07:18
18f637e
to
4a8c25c
Compare
baixinsui
force-pushed
the
feat/deployer_with_version
branch
8 times, most recently
from
October 11, 2024 03:21
966426c
to
0c99f9a
Compare
baixinsui
force-pushed
the
feat/deployer_with_version
branch
4 times, most recently
from
October 11, 2024 07:29
f069e57
to
644e92e
Compare
swaroopar
requested changes
Oct 11, 2024
modules/deployment/src/main/java/org/eclipse/xpanse/modules/deployment/DeployService.java
Outdated
Show resolved
Hide resolved
modules/deployment/src/main/java/org/eclipse/xpanse/modules/deployment/ServiceStateManager.java
Outdated
Show resolved
Hide resolved
baixinsui
force-pushed
the
feat/deployer_with_version
branch
from
October 11, 2024 08:57
644e92e
to
8dfa11a
Compare
swaroopar
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1941
OpenTofu with multiple versions:
Terraform with multiple versions: