handle still in-progress requests in getStoredTaskResultByRequestId #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangLiNaruto
force-pushed
the
feature/handler_in_process
branch
2 times, most recently
from
2ecb5f7 to
1468f7e
Compare
WangLiNaruto
force-pushed
the
feature/handler_in_process
branch
from
1468f7e to
0e83019
Compare
swaroopar
approved these changes
Nov 27, 2024
| } catch (IOException e) { | ||
| log.error("Failed to retrieve OpenTofuResult for requestId: {}", requestId, e); | ||
| throw new ResultAlreadyReturnedOrRequestIdInvalidException( | ||
| "Failed to retrieve OpenTofuResult for requestId: " + requestId); | ||
| } | ||
| } | ||
|
|
||
| private boolean isDeployInProcess(String requestId) { |
There was a problem hiding this comment.
please rename this to isDeployStillInProgress()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed eclipse-xpanse/xpanse#2131