terraform-boot - Enable async processing of deploy and destroy API me… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
aeef498 to
2fc0dc8
Compare
swaroopar
requested changes
Aug 24, 2023
There was a problem hiding this comment.
@WangLiNaruto the PR seems to have taken a wrong direction. We do not need all this.
We only need the script to be executed asynchronously and then provide a response using webhook.
src/main/java/org/eclipse/xpanse/terraform/boot/config/TerraformVersionProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/xpanse/terraform/boot/models/providers/Aws.java
Outdated
Show resolved
Hide resolved
src/main/java/org/eclipse/xpanse/terraform/boot/models/request/TerraformDeployRequest.java
Outdated
Show resolved
Hide resolved
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
2fc0dc8 to
bf23036
Compare
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
2 times, most recently
from
7191043 to
b77602c
Compare
swaroopar
reviewed
Aug 29, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/terraform/TerraformExecutor.java
Show resolved
Hide resolved
swaroopar
reviewed
Aug 29, 2023
...java/org/eclipse/xpanse/terraform/boot/models/request/TerraformDeployWithScriptsRequest.java
Outdated
Show resolved
Hide resolved
swaroopar
requested changes
Aug 29, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/api/TerraformApiController.java
Outdated
Show resolved
Hide resolved
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
b77602c to
2e6d99e
Compare
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
7426b61 to
27f7d1c
Compare
swaroopar
reviewed
Aug 30, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/terraform/service/TerraformScriptsService.java
Outdated
Show resolved
Hide resolved
swaroopar
requested changes
Aug 30, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/api/TerraformApiController.java
Outdated
Show resolved
Hide resolved
swaroopar
reviewed
Aug 30, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/terraform/service/TerraformScriptsService.java
Outdated
Show resolved
Hide resolved
swaroopar
reviewed
Aug 30, 2023
src/main/java/org/eclipse/xpanse/terraform/boot/terraform/service/TerraformScriptsService.java
Show resolved
Hide resolved
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
27f7d1c to
2756886
Compare
…s in request body
WangLiNaruto
force-pushed
the
feature/enable_async_deploy
branch
from
2756886 to
d7d4fa6
Compare
swaroopar
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed eclipse-xpanse/xpanse#803
Fixed eclipse-xpanse/xpanse#804