Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for datetime2 data type #751

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Support for datetime2 data type #751

merged 1 commit into from
Jan 13, 2021

Conversation

tsegismont
Copy link
Contributor

See #608

@tsegismont tsegismont mentioned this pull request Aug 31, 2020
Closed
vietj
vietj reviewed Sep 1, 2020
View reviewed changes
Copy link
Member

@vietj vietj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see many reformatting changes because your IDE is configured differently for rewritten (type == String.class) as (type==String.class) can you remove those un-necessary changes ?

@tsegismont
Copy link
Contributor Author

My IDE settings are correct, those lines were re-formatted because IDEA formats changed method bodies. It's just a few of them in a couple of methods.

@tsegismont
Copy link
Contributor Author

@vietj anything else beyond formatting?

@vietj
Copy link
Member

vietj commented Sep 7, 2020

@tsegismont you seem to have peculiar IDE settings. Most vertx code base uses == , so that is a concern because the code you will be committing will always conflict and rewrite the code base, other committers (like me) will have their IDE reformat the other and it will be very confusing, so you should change your IDE settings to match this rule.

@tsegismont
Copy link
Contributor Author

@vietj I use IDEA with default settings + the plugin for .editorconfig file. Not sure why but spaces around == got unchecked. I've updated my config and the PR.

Anything else beyond formatting?

@tsegismont tsegismont modified the milestone: 4.0.0 Sep 9, 2020
@tsegismont tsegismont added this to the 4.0.1 milestone Jan 6, 2021
@vietj
Copy link
Member

vietj commented Jan 12, 2021

can you rebase @tsegismont ?

@tsegismont
Copy link
Contributor Author

@vietj just rebased on master. Can I merge when the GH checks are all green or do you want to take another look?

BillyYccc
BillyYccc reviewed Jan 13, 2021
View reviewed changes
vertx-mssql-client/src/main/java/io/vertx/mssqlclient/impl/codec/ExtendedQueryCommandCodec.java
@@ -207,6 +208,8 @@ private void encodeParamValue(ByteBuf payload, Object value) {
encodeDateNParameter(payload, (LocalDate) value);
} else if (value instanceof LocalTime) {
encodeTimeNParameter(payload, (LocalTime) value, (byte) 6);
} else if (value instanceof LocalDateTime) {
encodeDateTimeNParameter(payload, (LocalDateTime) value, (byte) 6);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opinions about the scale? I'm not sure if I ever got it right to hardcode it as 6 to not truncating any nano seconds in the LocalTime parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed #752 to make sure we analyze and take any action needed.

@tsegismont tsegismont merged commit 566f8ad into eclipse-vertx:master Jan 13, 2021
@tsegismont tsegismont deleted the datetime2 branch January 13, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyYccc BillyYccc BillyYccc left review comments

@vietj vietj vietj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tsegismont @vietj @BillyYccc