Skip to content

Commit

Permalink
Add more extensive testing for DATETIMN
Browse files Browse the repository at this point in the history
  • Loading branch information
@rasmushaglund
rasmushaglund committed Sep 16, 2021
1 parent 1951c6e commit cb4a4fc
Show file tree
Hide file tree
Showing 5 changed files with 75 additions and 10 deletions.
14 changes: 14 additions & 0 deletions vertx-mssql-client/src/test/java/io/vertx/mssqlclient/data/MSSQLFullDataTypeTestBase.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public void testDecodeAllColumns(TestContext ctx) {
ctx.assertEquals("testvarchar", row.getValue("test_varchar"));
ctx.assertEquals(LocalDate.of(2019, 1, 1), row.getValue("test_date"));
ctx.assertEquals(LocalTime.of(18, 45, 2), row.getValue("test_time"));
ctx.assertEquals(LocalDateTime.of(2019, 1, 1, 18, 45, 2), row.getValue("test_datetime"));
ctx.assertEquals(LocalDateTime.of(2019, 1, 1, 18, 45, 2), row.getValue("test_datetime2"));
ctx.assertEquals(LocalDateTime.of(2019, 1, 1, 18, 45, 2).atOffset(ZoneOffset.ofHoursMinutes(-3, -15)), row.getValue("test_datetimeoffset"));
ctx.assertEquals(Buffer.buffer("hello world").appendBytes(new byte[20 - "hello world".length()]), row.getValue("test_binary"));
Expand Down Expand Up @@ -160,6 +161,19 @@ public void testDecodeTime(TestContext ctx) {

@Test
public void testDecodeDateTime(TestContext ctx) {
testDecodeNotNullValue(ctx, "test_datetime", row -> {
ColumnChecker.checkColumn(0, "test_datetime")
.returns(Tuple::getValue, Row::getValue, LocalDateTime.of(2019, 1, 1, 18, 45, 2))
.returns(Tuple::getLocalDateTime, Row::getLocalDateTime, LocalDateTime.of(2019, 1, 1, 18, 45, 2))
.returns(Tuple::getLocalDate, Row::getLocalDate, LocalDate.of(2019, 1, 1))
.returns(Tuple::getLocalTime, Row::getLocalTime, LocalTime.of(18, 45, 2))
.returns(LocalDateTime.class, LocalDateTime.of(2019, 1, 1, 18, 45, 2))
.forRow(row);
});
}

@Test
public void testDecodeDateTime2(TestContext ctx) {
testDecodeNotNullValue(ctx, "test_datetime2", row -> {
ColumnChecker.checkColumn(0, "test_datetime2")
.returns(Tuple::getValue, Row::getValue, LocalDateTime.of(2019, 1, 1, 18, 45, 2))
Expand Down
10 changes: 10 additions & 0 deletions ...x-mssql-client/src/test/java/io/vertx/mssqlclient/data/MSSQLNullableDataTypeTestBase.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ public void testDecodeNullAllColumns(TestContext ctx) {
ctx.assertEquals(null, row.getValue("test_varchar"));
ctx.assertEquals(null, row.getValue("test_date"));
ctx.assertEquals(null, row.getValue("test_time"));
ctx.assertEquals(null, row.getValue("test_datetime"));
ctx.assertEquals(null, row.getValue("test_datetime2"));
ctx.assertEquals(null, row.getValue("test_datetimeoffset"));
ctx.assertEquals(null, row.getValue("test_binary"));
Expand Down Expand Up @@ -183,6 +184,15 @@ public void testDecodeNullTime(TestContext ctx) {

@Test
public void testDecodeNullDateTime(TestContext ctx) {
testDecodeNullValue(ctx, "test_datetime", row -> {
ColumnChecker.checkColumn(0, "test_datetime")
.returnsNull()
.forRow(row);
});
}

@Test
public void testDecodeNullDateTime2(TestContext ctx) {
testDecodeNullValue(ctx, "test_datetime2", row -> {
ColumnChecker.checkColumn(0, "test_datetime2")
.returnsNull()
Expand Down
18 changes: 18 additions & 0 deletions ...nt/src/test/java/io/vertx/mssqlclient/data/MSSQLPreparedQueryNotNullableDataTypeTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,24 @@ public void testEncodeTime(TestContext ctx) {
@Test
@Repeat(100)
public void testEncodeDateTime(TestContext ctx) {
LocalDateTime now = LocalDateTime.now();
// Reduce accuracy since datatype accuracy is rounded to increments of .000, .003, or .007 seconds
int nanoOfDay = (int) Math.round(Math.round((now.getNano()/1000000d)/3.333333)*3.333333)*1000000;
LocalDateTime convertedNow = now.withNano(nanoOfDay);
testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_datetime", now, row -> {
ColumnChecker.checkColumn(0, "test_datetime")
.returns(Tuple::getValue, Row::getValue, convertedNow)
.returns(Tuple::getLocalDateTime, Row::getLocalDateTime, convertedNow)
.returns(Tuple::getLocalDate, Row::getLocalDate, convertedNow.toLocalDate())
.returns(Tuple::getLocalTime, Row::getLocalTime, convertedNow.toLocalTime())
.returns(LocalDateTime.class, convertedNow)
.forRow(row);
});
}

@Test
@Repeat(100)
public void testEncodeDateTime2(TestContext ctx) {
LocalDateTime now = LocalDateTime.now();
testPreparedQueryEncodeGeneric(ctx, "not_nullable_datatype", "test_datetime2", now, row -> {
ColumnChecker.checkColumn(0, "test_datetime2")
Expand Down
21 changes: 21 additions & 0 deletions ...lient/src/test/java/io/vertx/mssqlclient/data/MSSQLPreparedQueryNullableDataTypeTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,27 @@ public void testEncodeNullDateTime(TestContext ctx) {
}

private void testEncodeDateTimeValue(TestContext ctx, LocalDateTime value) {
testPreparedQueryEncodeGeneric(ctx, "nullable_datatype", "test_datetime", value, row -> {
ColumnChecker checker = ColumnChecker.checkColumn(0, "test_datetime");
if (value == null) {
checker.returnsNull();
} else {
checker.returns(Tuple::getValue, Row::getValue, value)
.returns(Tuple::getLocalDateTime, Row::getLocalDateTime, value)
.returns(Tuple::getLocalDate, Row::getLocalDate, value.toLocalDate())
.returns(Tuple::getLocalTime, Row::getLocalTime, value.toLocalTime())
.returns(LocalDateTime.class, value)
.forRow(row);
}
});
}

@Test
public void testEncodeNullDateTime2(TestContext ctx) {
testEncodeDateTime2Value(ctx, LOCALDATETIME_NULL_VALUE);
}

private void testEncodeDateTime2Value(TestContext ctx, LocalDateTime value) {
testPreparedQueryEncodeGeneric(ctx, "nullable_datatype", "test_datetime2", value, row -> {
ColumnChecker checker = ColumnChecker.checkColumn(0, "test_datetime2");
if (value == null) {
Expand Down
22 changes: 12 additions & 10 deletions vertx-mssql-client/src/test/resources/init.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ CREATE TABLE nullable_datatype
test_varchar VARCHAR(20),
test_date DATE,
test_time TIME(5),
test_datetime DATETIME,
test_datetime2 DATETIME2(4),
test_datetimeoffset DATETIMEOFFSET(3),
test_binary BINARY(20),
Expand All @@ -101,20 +102,20 @@ CREATE TABLE nullable_datatype

INSERT INTO nullable_datatype(id, test_tinyint, test_smallint, test_int, test_bigint, test_float_4, test_float_8,
test_numeric, test_decimal, test_boolean, test_char, test_varchar, test_date, test_time,
test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
test_datetime, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (1, 127, 32767, 2147483647, 9223372036854775807, 3.40282E38, 1.7976931348623157E308, 999.99,
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02',
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02', '2019-01-01T18:45:02',
'2019-01-01T18:45:02-03:15', CONVERT(VARBINARY, 'hello world'), CONVERT(VARBINARY, 'big apple'));
INSERT INTO nullable_datatype(id, test_tinyint, test_smallint, test_int, test_bigint, test_float_4, test_float_8,
test_numeric, test_decimal, test_boolean, test_char, test_varchar, test_date, test_time,
test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
test_datetime, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (2, 127, 32767, 2147483647, 9223372036854775807, 3.40282E38, 1.7976931348623157E308, 999.99,
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02',
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02', '2019-01-01T18:45:02',
'2019-01-01T18:45:02-03:15', CONVERT(VARBINARY, 'hello world'), CONVERT(VARBINARY, 'big apple'));
INSERT INTO nullable_datatype(id, test_tinyint, test_smallint, test_int, test_bigint, test_float_4, test_float_8,
test_numeric, test_decimal, test_boolean, test_char, test_varchar, test_date, test_time,
test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (3, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
test_datetime, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (3, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
-- table for testing nullable data types

-- table for testing NOT NULL data types
Expand All @@ -135,6 +136,7 @@ CREATE TABLE not_nullable_datatype
test_varchar VARCHAR(20) NOT NULL,
test_date DATE NOT NULL,
test_time TIME(6) NOT NULL,
test_datetime DATETIME NOT NULL,
test_datetime2 DATETIME2(7) NOT NULL,
test_datetimeoffset DATETIMEOFFSET(5) NOT NULL,
test_binary BINARY(20) NOT NULL,
Expand All @@ -143,15 +145,15 @@ CREATE TABLE not_nullable_datatype

INSERT INTO not_nullable_datatype(id, test_tinyint, test_smallint, test_int, test_bigint, test_float_4, test_float_8,
test_numeric, test_decimal, test_boolean, test_char, test_varchar, test_date,
test_time, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
test_time, test_datetime, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (1, 127, 32767, 2147483647, 9223372036854775807, 3.40282E38, 1.7976931348623157E308, 999.99,
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02',
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02', '2019-01-01T18:45:02',
'2019-01-01T18:45:02-03:15', CONVERT(VARBINARY, 'hello world'), CONVERT(VARBINARY, 'big apple'));
INSERT INTO not_nullable_datatype(id, test_tinyint, test_smallint, test_int, test_bigint, test_float_4, test_float_8,
test_numeric, test_decimal, test_boolean, test_char, test_varchar, test_date,
test_time, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
test_time, test_datetime, test_datetime2, test_datetimeoffset, test_binary, test_varbinary)
VALUES (2, 127, 32767, 2147483647, 9223372036854775807, 3.40282E38, 1.7976931348623157E308, 999.99,
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02',
12345, 1, 'testchar', 'testvarchar', '2019-01-01', '18:45:02', '2019-01-01T18:45:02', '2019-01-01T18:45:02',
'2019-01-01T18:45:02-03:15', CONVERT(VARBINARY, 'hello world'), CONVERT(VARBINARY, 'big apple'));
-- table for testing NOT NULL data types

Expand Down

0 comments on commit cb4a4fc

Please sign in to comment.