fix batch 4

src/main/java/io/vertx/httpproxy/impl/CachingFilter.java

@@ -42,7 +42,7 @@ private Future<Void> sendAndTryCacheProxyResponse(ProxyContext context) {
     if (cached != null && response.getStatusCode() == 304) {
       // Warning: this relies on the fact that HttpServerRequest will not send a body for HEAD
       response.release();
-      cached.init(response);
+      fillResponseFromResource(response, cached);
       return context.sendResponse();
     }
 
@@ -138,9 +138,16 @@ private Future<ProxyResponse> tryHandleProxyRequestFromCache(ProxyContext contex
       }
       proxyRequest.release();
       ProxyResponse proxyResponse = proxyRequest.response();
-      resource.init(proxyResponse);
+      fillResponseFromResource(proxyResponse, resource);
       return Future.succeededFuture(proxyResponse);
     });
 
   }
+
+  public void fillResponseFromResource(ProxyResponse proxyResponse, Resource resource) {
+    proxyResponse.setStatusCode(200);
+    proxyResponse.setStatusMessage(resource.getStatusMessage());
+    proxyResponse.headers().addAll(resource.getHeaders());
+    proxyResponse.setBody(Body.body(resource.getContent()));
+  }
 }

src/main/java/io/vertx/httpproxy/spi/cache/Cache.java

@@ -24,7 +24,7 @@ public interface Cache {
    * Being called when the proxy attempts to fetch a cache item.
    *
    * @param key the URI of the resource
-   * @return the cached response, null if not exist
+   * @return the cached response, null if not exist, should all wrap with future
    */
   Future<Resource> get(String key);
 

src/main/java/io/vertx/httpproxy/spi/cache/Resource.java

@@ -55,13 +55,6 @@ public Resource(String absoluteUri, int statusCode, String statusMessage, MultiM
     this.etag = headers.get(HttpHeaders.ETAG);
   }
 
-  public void init(ProxyResponse proxyResponse) {
-    proxyResponse.setStatusCode(200);
-    proxyResponse.setStatusMessage(statusMessage);
-    proxyResponse.headers().addAll(headers);
-    proxyResponse.setBody(Body.body(content));
-  }
-
   private static class Cursor {
     int i;
   }