Preserve declaration order for data object properties. #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the declarations provided by the annotation processor element. In order to allows users reason about protobuf generation where the order matters, we need this order to be preserved. Update the DataObjectModel implementation to conserve the declaration order as provided by the annotation processor. This changes the existing behavior that was sorting the elements using their name as sorting element.
vietj
force-pushed
the
order-data-object-members
branch
from
332cd66 to
77c30e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The processor for data objects does not converse the natural order of the declarations provided by the annotation processor element. In order to allows users reason about protobuf generation where the order matters, we need this order to be preserved.
Update the DataObjectModel implementation to conserve the declaration order as provided by the annotation processor. This changes the existing behaviour that was sorting the elements using their name as sorting element.