Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use custom mapper on Enum #341

Merged
merged 4 commits into from
Oct 20, 2021
Merged

Conversation

Fyro-Ing
Copy link
Contributor

Allow to use custom mapper on Enum define with values parameters passed to a constructor

Fix #295

@vietj
Copy link
Member

vietj commented Oct 12, 2021

See also vert-x3/vertx-rx#235

@Fyro-Ing
Copy link
Contributor Author

ok, i will check that this week-end

@vietj
Copy link
Member

vietj commented Oct 18, 2021

@Fyro-Ing

I think we are missing a test to ensure that the JSON generated converters will use the mapper.

Please have a look at the src/converters/resources/META-INF/vertx/json-mappers.properties file and the TestDataObject which has a methodMapped property that uses a converter for a ZonedDateTime

We need the same for this new feature.

@vietj
Copy link
Member

vietj commented Oct 19, 2021

@Fyro-Ing can we get the missing test soon for Vert.x 4.2 release ?

@Fyro-Ing
Copy link
Contributor Author

I do it now

@vietj vietj merged commit 6082252 into eclipse-vertx:master Oct 20, 2021
@vietj
Copy link
Member

vietj commented Oct 20, 2021

thanks for the contribution @Fyro-Ing @cvgaviao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An mapper specified for a Enum is not being considered by anotation processor
3 participants