Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure access_token is available after introspect #660

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

chrispatmore
Copy link
Contributor

Update the code to ensure the access token is available after validating the token using token introspect

Motivation:

Contributes to: #659

Update the code to ensure the access token is available after
validating the token using token introspect

Contributes to: eclipse-vertx#659

Signed-off-by: Chris Patmore <[email protected]>
@chrispatmore
Copy link
Contributor Author

chrispatmore commented Aug 30, 2023

I would prefer not to put the token introspect response JSON as the principal JSON as I don't think they're really the same thing, and I have seen (Keycloak for example) returns username as well as sub and then when that json is placed as the principal (not under idToken or other) the User created returns the username as the subject() instead of the sub which is what is returned if the token validates / if there is an idToken

But. I can see that being a breaking change for those relying on it behaving as is at the moment, so I could accept that I just have to include a workaround to fix the subject post authentication

@pmlopes pmlopes added the bug label Oct 11, 2023
@pmlopes pmlopes added this to the 5.0.0 milestone Oct 11, 2023
@pmlopes pmlopes merged commit 0690b9f into eclipse-vertx:master Oct 11, 2023
@pmlopes
Copy link
Contributor

pmlopes commented Oct 11, 2023

We can accept this behavior change as we are targetting to 5.0.0

@chrispatmore chrispatmore deleted the 659-keep-access-token branch October 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants