Remove DatabindCodec pretty mapper #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change relieves users from configuring two object mappers if they have customizations. For Vert.x, it is not less efficient to use a writer with pretty printer when encoding json. Signed-off-by: Thomas Segismont <[email protected]>
|
@vietj this is a proposal for Vert.x 5. If we agree on this, I will deprecate the pretty mapper in |
|
what is the rationale behind that ? I might have missed it |
|
The rationale is simplification. There is no need to keep two object mappers if a single one can be used to encode json in compact and pretty form. |
|
that makes sense |
vietj
approved these changes
Jan 9, 2024
Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relieves users from configuring two object mappers if they have customizations.
For Vert.x, it is not less efficient to use a writer with pretty printer when encoding json.