HostAndPort fails to parse a nip host

[tsegismont]

See #4947

If parseIPv4Address finds an IP address, and the string still has characters which do not begin with :, this is not an IP address.

In other words, 10.0.0.1.nip.io should not be parsed as IP address.

[vietj]

I am not certain this is the correct fix to do

[vietj]

The fix makes reg names parsed as IPV4 addresses when they are prefixed by an IPV4 string which makes the impl of parseIPv4Address wrong as it accepts more than it should and testParseIPV4Address has been added incorrect assertions.

Instead the code using parseIPV4Address should check when this method returns a positive value, than the returned position is actually the end of the string or followed by :.

The correct thing to do should be

  static int parseHost(String val, int from, int to) {
    int pos;
    if ((pos = parseIPLiteral(val, from, to)) != -1) {
      return pos;
    } else if ((pos = parseIPv4Address(val, from, to)) != -1 && (pos == to || val.charAt(pos + 1 ) == ':') ) {
      return pos;
    } else if ((pos = parseRegName(val, from, to)) != -1) {
      return pos;
    }
    return -1;
  }