Clarify MessageProducer write future behavior #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See eclipse-vertx#4922 When publishing, the OutboundDeliveryContext (promise) can be completed or failed several times. This leads to confusing exceptions in application logs. The promise should be completed with tryFail/tryComplete to avoid redundant exceptions. Besides, the MessageProducer write future behavior should be clarified. The returned Future completion depends on the producer type: - send or request: the future is completed successfully if the message has been written; otherwise, the future is failed - publish: the future is failed if there is no recipient; otherwise, the future is completed successfully In any case, a successfully completed Future is not a delivery guarantee. Signed-off-by: Thomas Segismont <[email protected]>
vietj
approved these changes
Nov 8, 2023
tsegismont
added a commit
that referenced
this pull request
Nov 9, 2023
See #4922 When publishing, the OutboundDeliveryContext (promise) can be completed or failed several times. This leads to confusing exceptions in application logs. The promise should be completed with tryFail/tryComplete to avoid redundant exceptions. Besides, the MessageProducer write future behavior should be clarified. The returned Future completion depends on the producer type: - send or request: the future is completed successfully if the message has been written; otherwise, the future is failed - publish: the future is failed if there is no recipient; otherwise, the future is completed successfully In any case, a successfully completed Future is not a delivery guarantee. Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4922
When publishing, the OutboundDeliveryContext (promise) can be completed or failed several times. This leads to confusing exceptions in application logs.
The promise should be completed with tryFail/tryComplete to avoid redundant exceptions.
Besides, the MessageProducer write future behavior should be clarified. The returned Future completion depends on the producer type:
In any case, a successfully completed Future is not a delivery guarantee.