Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client proxy enhancements #3919

Merged
merged 1 commit into from
May 17, 2021
Merged

Client proxy enhancements #3919

merged 1 commit into from
May 17, 2021

Conversation

vietj
Copy link
Member

@vietj vietj commented May 12, 2021 •
edited
Loading

  • nonProxyHost support
  • per HTTP request / WebSocket proxy options

@vietj vietj added this to the 4.1.0 milestone May 12, 2021
@vietj vietj force-pushed the non-proxy-hosts branch 3 times, most recently from 1df6d8a to 53c2058 Compare May 12, 2021 07:37
@vietj
Non proxy host options for TCP clients, per HTTP request proxy options.
83e86b0 
Clients have been modified to filter proxy options based on a list of hosts support. Host declaration accept wildcard match like JVM nonProxyHosts list.

HTTP requests declares now a ProxyOptions property that will set the proxy options per request and override the client configuration.

fixes #2600
fixes #3795
@vietj vietj force-pushed the non-proxy-hosts branch from 53c2058 to 83e86b0 Compare May 12, 2021 08:32
@vietj vietj marked this pull request as ready for review May 12, 2021 08:41
@vietj
Copy link
Member Author

vietj commented May 12, 2021

@vsevel @cescoffier here is the proxy support enhancements for 4.1, do you mind having a look ?

@vietj vietj changed the title Non proxy hosts support Client proxy enhancements May 12, 2021
@vsevel vsevel mentioned this pull request May 13, 2021
Closed
@vietj
Copy link
Member Author

vietj commented May 17, 2021

@vsevel @cescoffier can you check this PR responds to the issue appropriately ?

cescoffier
cescoffier approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't have a complete understanding of the root (Vault) issue.

@vietj
Copy link
Member Author

vietj commented May 17, 2021

alright let's merge this as this is a general purpose feature

@vietj vietj merged commit 1e95256 into master May 17, 2021
@vietj vietj deleted the non-proxy-hosts branch May 17, 2021 09:57
@vsevel
Copy link

vsevel commented May 18, 2021

could not get @fmarissel to validate the feature. whenever vertx 4.1 is available in quarkus, I will expose the new nonProxyHost property in the vault's config, in the context of quarkusio/quarkus#16453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vietj @vsevel @cescoffier