Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventBus inbound interceptors are never removed #4422

Closed
tsegismont opened this issue Jun 28, 2022 · 0 comments · Fixed by #4423
Closed

EventBus inbound interceptors are never removed #4422

tsegismont opened this issue Jun 28, 2022 · 0 comments · Fixed by #4423
Assignees
Labels
Milestone

Comments

@tsegismont
Copy link
Contributor

Since 4.3.0, EventBus interceptors are managed with AtomicReferenceFieldUpdater.

But io.vertx.core.eventbus.impl.EventBusImpl#removeInboundInterceptor uses the wrong instance:

@Override
public <T> EventBus removeInboundInterceptor(Handler<DeliveryContext<T>> interceptor) {
removeInterceptor(OUTBOUND_INTERCEPTORS_UPDATER, interceptor);
return this;
}

@tsegismont tsegismont added the bug label Jun 28, 2022
@tsegismont tsegismont added this to the 4.3.2 milestone Jun 28, 2022
@tsegismont tsegismont self-assigned this Jun 28, 2022
tsegismont added a commit to tsegismont/vert.x that referenced this issue Jun 28, 2022
…_UPDATER

Fixes eclipse-vertx#4422

Otherwise, no inbound interceptor will ever be removed.

Signed-off-by: Thomas Segismont <[email protected]>
tsegismont added a commit to tsegismont/vert.x that referenced this issue Jun 28, 2022
…_UPDATER

Fixes eclipse-vertx#4422

Otherwise, no inbound interceptor will ever be removed.

Signed-off-by: Thomas Segismont <[email protected]>
tsegismont added a commit that referenced this issue Jun 28, 2022
…_UPDATER (#4423)

Fixes #4422

Otherwise, no inbound interceptor will ever be removed.

Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant