Skip to content

Commit

Permalink
Rename test build properties.
Browse files Browse the repository at this point in the history
Motivation:

The useModulePath property for testing is now provided by vertx5-parent and is named vertx.surefire.useModulePath. Rename vertx-core specific properties to follow the same pattern.

Changes:

- vertx.testUseDomainSockets -> vertx.surefire.useDomainSockets
- vertx.testTransport -> vertx.surefire.nettyTransport
- update README accordingly
  • Loading branch information
vietj committed Jan 7, 2025
1 parent 4b44d70 commit 8e05f2b
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 21 deletions.
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,18 @@ Tests can be run with specified HTTP port and/or HTTPS port.
Vert.x supports native transport on BSD and Linux, to run the tests with native transport

```
> mvn test -PtestNativeTransport
> mvn test -PNativeEpoll
> mvn test -PNativeIoUring
> mvn test -PNativeKQueue
```

Vert.x supports domain sockets on Linux exclusively, to run the tests with domain sockets

```
> mvn test -PtestDomainSockets
> mvn test -PNativeEpoll+DomainSockets
```

Vert.x has a few integrations tests that run a differently configured JVM (classpath, system properties, etc....)
for ALPN, native and logging
Vert.x has integrations tests that run a differently configured JVM (classpath, system properties, etc....)

```
> vertx verify -Dtest=FooTest # FooTest does not exists, its only purpose is to execute no tests during the test phase
Expand Down
34 changes: 17 additions & 17 deletions vertx-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
<apacheds-protocol-dns.version>2.0.0.AM27</apacheds-protocol-dns.version>
<generated.dir>${project.basedir}/src/main/generated</generated.dir>
<jmh.version>1.37</jmh.version>
<vertx.testTransport>jdk</vertx.testTransport>
<vertx.testDomainSockets>false</vertx.testDomainSockets>
<vertx.surefire.nettyTransport>jdk</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
</properties>

<dependencies>
Expand Down Expand Up @@ -252,8 +252,8 @@
<buildDirectory>${project.build.directory}</buildDirectory>
<vertx.version>${project.version}</vertx.version>
<vertx.handle100Continue>true</vertx.handle100Continue>
<vertx.transport>${vertx.testTransport}</vertx.transport>
<vertx.useDomainSockets>${vertx.testDomainSockets}</vertx.useDomainSockets>
<vertx.transport>${vertx.surefire.nettyTransport}</vertx.transport>
<vertx.useDomainSockets>${vertx.surefire.useDomainSockets}</vertx.useDomainSockets>
<vertx.threadChecks>true</vertx.threadChecks>
</systemPropertyVariables>
<!-- Needs to be small enough to run in a EC2 1.7GB small instance -->
Expand Down Expand Up @@ -696,45 +696,45 @@
<profile>
<id>NativeEpoll</id>
<properties>
<vertx.testTransport>epoll</vertx.testTransport>
<vertx.testDomainSockets>false</vertx.testDomainSockets>
<vertx.testUseModulePath>false</vertx.testUseModulePath>
<vertx.surefire.nettyTransport>epoll</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
</properties>
</profile>

<profile>
<id>NativeIoUring</id>
<properties>
<vertx.testTransport>io_uring</vertx.testTransport>
<vertx.testDomainSockets>false</vertx.testDomainSockets>
<vertx.surefire.nettyTransport>io_uring</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
</properties>
</profile>

<profile>
<id>NativeEpoll+DomainSockets</id>
<properties>
<vertx.testTransport>epoll</vertx.testTransport>
<vertx.testDomainSockets>true</vertx.testDomainSockets>
<vertx.surefire.nettyTransport>epoll</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>true</vertx.surefire.useDomainSockets>
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
</properties>
</profile>

<profile>
<id>NativeKQueue</id>
<properties>
<vertx.testTransport>kqueue</vertx.testTransport>
<vertx.testDomainSockets>false</vertx.testDomainSockets>
<vertx.testUseModulePath>false</vertx.testUseModulePath>
<vertx.surefire.nettyTransport>kqueue</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>false</vertx.surefire.useDomainSockets>
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
</properties>
</profile>

<profile>
<id>NativeKQueue+DomainSockets</id>
<properties>
<vertx.testTransport>kqueue</vertx.testTransport>
<vertx.testDomainSockets>true</vertx.testDomainSockets>
<vertx.testUseModulePath>false</vertx.testUseModulePath>
<vertx.surefire.nettyTransport>kqueue</vertx.surefire.nettyTransport>
<vertx.surefire.useDomainSockets>true</vertx.surefire.useDomainSockets>
<vertx.surefire.useModulePath>false</vertx.surefire.useModulePath>
</properties>
</profile>

Expand Down

0 comments on commit 8e05f2b

Please sign in to comment.