Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to Node20 #11

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Jun 14, 2024

We get warnings when using old version, see https://github.com/erikbosch/vehicle-example-app2/actions/runs/9515702284

This PR updates that.

It has been verified in https://github.com/erikbosch/vehicle-example-app2/actions/runs/9516231971

(If we have a any particular reason to use Node 12 please let me know)

@erikbosch erikbosch force-pushed the erik_dep branch 2 times, most recently from 7509150 to 5445dc4 Compare June 14, 2024 12:35
@erikbosch erikbosch changed the title Test moving to Node20 Moving to Node20 Jun 14, 2024
@erikbosch erikbosch requested review from BjoernAtBosch and MP91 June 14, 2024 12:44
Copy link
Member

@BjoernAtBosch BjoernAtBosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikbosch erikbosch marked this pull request as ready for review June 24, 2024 09:40
@erikbosch erikbosch merged commit 3c2b4e0 into eclipse-velocitas:main Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants