Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added proxy into docker-in-docker config #56

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

kse3hi
Copy link
Contributor

@kse3hi kse3hi commented Oct 26, 2023

This is neccesary to handle proxy with "base" images

@kse3hi kse3hi requested a review from doosuu October 26, 2023 11:57
doosuu
doosuu previously requested changes Oct 27, 2023
.devcontainer/scripts/configure-proxies.sh Outdated Show resolved Hide resolved
.devcontainer/scripts/configure-proxies.sh Outdated Show resolved Hide resolved
.devcontainer/scripts/configure-proxies.sh Outdated Show resolved Hide resolved
@kse3hi kse3hi requested review from doosuu and dennismeister93 and removed request for doosuu October 27, 2023 09:17
Copy link
Contributor

@dennismeister93 dennismeister93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kse3hi kse3hi merged commit 1fb7a33 into main Nov 2, 2023
5 checks passed
@kse3hi kse3hi deleted the feature/add_proxy_docker-in-docker branch November 2, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants