Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing vulnerability #349

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NOTICE-3RD-PARTY-CONTENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
|convert-source-map|2.0.0|MIT|
|core-util-is|1.0.3|MIT|
|create-require|1.1.1|MIT|
|cross-spawn|7.0.3|MIT|
|cross-spawn|7.0.6|MIT|
|debug|4.3.7|MIT|
|decamelize|1.2.0|MIT|
|decamelize|4.0.0|MIT|
Expand Down
25 changes: 25 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -449,3 +449,28 @@ chmod -x /usr/bin/velocitas
- [GitHub Issues](https://github.com/eclipse-velocitas/cli/issues)
- [Mailing List](https://accounts.eclipse.org/mailing-list/velocitas-dev)
- [Contribution](CONTRIBUTING.md)

## Updating dependencies

Sometimes dependencies needs to be updated to address vulnerabilities.
If the vulnerability is known by npm (and a fix is published) you can typically request npm to update all existing vulnerabilities:

```bash
sudo npm audit fix
```

If the vulnerability is not (yet) considered as a vulnerability by npm you can update it manually:

```bash
sudo npm update cross-spawn
```

After updating you should do some basic checks that the tool is still working:

```bash
npm run build
```

After updating dependencies the file `NOTICE-3RD-PARTY-CONTENT.md` needs to be updated.
The easiest way to do this is to create a Pull Request (preferably as draft),
then the "Check Licenses" workflow will fail but as output produce content that you can add to the Pull Request.
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.