Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assemble-repository: Prevent sources from being included inadvertently #3635

Merged
merged 1 commit into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. assemble-repository: Prevent sources from being included inadvertently

    In the presence of products, P2 adds a virtual 'tooling.source.default'
    IU which optionally depends on all sources.
    
    If these sources are available in the target platform, this would cause
    them to be picked up even if assemble-repository was configured with
    
      <includeAllDependencies>true<includeAllDependencies>
    
    but with
    
      <includeAllSources>false</includeAllSources>.
    
    This scenario has become much more likely with recent changes to P2 [1].
    
    We do not want includeAllDependencies to imply includeAllSources, so
    we actively prevent this from happening by ignoring the
    
      <required namespace='org.eclipse.equinox.p2.eclipse.type'
                name='source'
                range='0.0.0'
                optional='true'
                multiple='true'
                greedy='false'/>
    
    requirements if 'includeAllSources' is not specified.
    
    Fixes eclipse-tycho#3522.
    
    [1] eclipse-equinox/p2#446
    sratz committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a028cbf View commit details
    Browse the repository at this point in the history