Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tycho-p2-director:director: Fix handling of destination on macOS #3549

Merged
merged 1 commit into from
Mar 26, 2024

Commits on Mar 26, 2024

  1. tycho-p2-director:director: Fix handling of destination on macOS

    * In DirectorMojo, the adjustment of 'destination' must consider the
      actual target environment (p2os/p2ws/p2arch parameters) that is to be
      installed and only fall back to the running environment if no explicit
      target environment is given.
    
    * Document in the tycho-p2-director:director JavaDoc / mojo parameter
      description that this intentionally deviates from the behavior of the
      stand-alone director application invocation:
          eclipse -application org.eclipse.equinox.p2.director
                  -destination <destination> ...
    
    * In DirectorMojo, add a consistency check that p2os/p2ws/p2arch must
      all be specified mutually.
    
    * The helper methods in DirectorRuntime are extended, to properly handle
      all three possible scenarios:
    
      1)     /path/without/app/bundle/layout
         --> /path/without/app/bundle/layout/Eclipse.app/Contents/Eclipse
    
      2)     /path/to/real.app/Contents/Eclipse
         --> /path/to/real.app/Contents/Eclipse
    
      3)     /path/to/real.app
         --> /path/to/real.app/Contents/Eclipse
    
      This allows us to remove redundant code in
      ProvisionedInstallationBuilder.
    
    * This also removes the <installAllPlatforms> option again which was
      introduced in eclipse-tycho#3091 (606a087).
      This is not used in production and was not having the desired effect.
    
      This simplifies the handling in AbstractEclipseTestMojo /
      ProvisionedInstallationBuilder even more.
    
    Fixes eclipse-tycho#3548.
    sratz committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    ffd4114 View commit details
    Browse the repository at this point in the history