Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GOAWAY handling #3492

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Improve GOAWAY handling #3492

merged 1 commit into from
Feb 9, 2024

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Feb 9, 2024

Currently GOAWAY is detected/handled only in the connection phase but sometimes can happen in the transfer phase as well.

This now wraps the whole request inside a block that is retried if a GOAWAY is detected.

@laeubi laeubi added the backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Test Results

  585 files    585 suites   3h 52m 49s ⏱️
  394 tests   387 ✅  7 💤 0 ❌
1 182 runs  1 160 ✅ 22 💤 0 ❌

Results for commit 0b27185.

♻️ This comment has been updated with latest results.

Currently GOAWAY is detected/handled only in the connection phase but
sometimes can happen in the transfer phase as well.

This now wraps the whole request inside a block that is retried if a
GOAWAY is detected.
@laeubi laeubi merged commit deb31c7 into eclipse-tycho:main Feb 9, 2024
11 checks passed
Copy link

github-actions bot commented Feb 9, 2024

💚 All backports created successfully

Status Branch Result
tycho-4.0.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-tycho-4.0.x Can be added to a PR to trigger an automatic backport of the change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant