Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.eclipse.platform:org.eclipse.equinox.p2.publisher.eclipse from 1.5.0 to 1.5.100 #2798

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 14, 2023

Bumps org.eclipse.platform:org.eclipse.equinox.p2.publisher.eclipse from 1.5.0 to 1.5.100.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Sep 14, 2023
@github-actions
Copy link

github-actions bot commented Sep 15, 2023

Test Results

   561 files  ±0     561 suites  ±0   5h 4m 22s ⏱️ - 25m 55s
   362 tests ±0     356 ✔️ ±0    6 💤 ±0  0 ±0 
1 086 runs  ±0  1 067 ✔️ ±0  19 💤 ±0  0 ±0 

Results for commit a3224f9. ± Comparison against base commit 603ee92.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch from 4a8e1e8 to 7f3a49b Compare September 15, 2023 05:50
@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch from 7f3a49b to 47a93e1 Compare September 15, 2023 14:54
@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch from 47a93e1 to 59e1ef6 Compare September 15, 2023 19:25
@akurtakov
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch from 59e1ef6 to 21f27c6 Compare September 18, 2023 06:33
@laeubi
Copy link
Member

laeubi commented Sep 18, 2023

This currently fails with

Caused by: java.lang.NoSuchMethodError: 'javax.xml.transform.TransformerFactory org.eclipse.equinox.internal.p2.core.helpers.SecureXMLUtil.createTransformerFactoryWithErrorOnDOCTYPE()'
    at org.eclipse.equinox.internal.p2.publisher.eclipse.InfoPListEditor.save (InfoPListEditor.java:72)
    at org.eclipse.equinox.internal.p2.publisher.eclipse.BrandingIron.modifyInfoPListFile (BrandingIron.java:575)
    at org.eclipse.equinox.internal.p2.publisher.eclipse.BrandingIron.brandMac (BrandingIron.java:243)
    at org.eclipse.equinox.internal.p2.publisher.eclipse.BrandingIron.brand (BrandingIron.java:125)
    at org.eclipse.equinox.p2.publisher.eclipse.EquinoxExecutableAction.fullBrandExecutables (EquinoxExecutableAction.java:267)
    at org.eclipse.equinox.p2.publisher.eclipse.EquinoxExecutableAction.brandExecutables (EquinoxExecutableAction.java:241)
    at org.eclipse.equinox.p2.publisher.eclipse.EquinoxExecutableAction.perform (EquinoxExecutableAction.java:71)
    at org.eclipse.equinox.p2.publisher.eclipse.ApplicationLauncherAction.perform (ApplicationLauncherAction.java:71)
    at org.eclipse.equinox.p2.publisher.eclipse.ProductAction.perform (ProductAction.java:148)
    at org.eclipse.equinox.p2.publisher.Publisher$ArtifactProcess.run (Publisher.java:242)

so it seems we need to update some other depedency here before @HannesWell might have further knowledge or @jukzi that where involved in this platform change.

@laeubi
Copy link
Member

laeubi commented Sep 18, 2023

@jukzi
Copy link

jukzi commented Sep 18, 2023

bump dependency
in org.eclipse.equinox.p2.publisher.eclipse
to org.eclipse.equinox.p2.core 2.10 (or even 2.10.200) should do the job

@laeubi
Copy link
Member

laeubi commented Sep 18, 2023

@dependabot rebase

Bumps [org.eclipse.platform:org.eclipse.equinox.p2.publisher.eclipse](https://github.com/eclipse-equinox/p2) from 1.5.0 to 1.5.100.
- [Commits](https://github.com/eclipse-equinox/p2/commits)

---
updated-dependencies:
- dependency-name: org.eclipse.platform:org.eclipse.equinox.p2.publisher.eclipse
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch from 21f27c6 to a3224f9 Compare September 18, 2023 10:11
@laeubi laeubi merged commit 7b23b0a into master Sep 18, 2023
8 checks passed
@dependabot dependabot bot deleted the dependabot/maven/org.eclipse.platform-org.eclipse.equinox.p2.publisher.eclipse-1.5.100 branch September 18, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants