Check if the about to be injected maven coordinates can be resolved #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
added
the
backport-to-tycho-4.0.x
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
|
@laeubi IIUIC, with this fix, the current behavior remains the same but with a better error message. On top of that, I can configure the resolver (not sure how) to ignore p2 metadata? |
|
Actually my plan was to turn it into a warning, need to investigate why this has worked for myl ocal test but not in general :-( Can you probably share the Stacktrace you see when running maven with |
|
Without changing any configuration and with And then with 3.0.5 (not snapshot): |
You need to use |
That makes more sense. I'm getting a new error for a different dependency now (of course no issue on 2.7.5, even with 4.0.0) Indeed, it seems like the transitive repository If I remove |
This is hard to tell without an example, but in general it seems your dependency is somehow missing an important thing, Tycho performs more deep analysis now so maybe transitive repository needs to be added to the target file to be found.
Fix the Xtext Updatesite :-) |
You mean all Eclipse's projects? As you can see from my logs I see the same for Orbit, EMF, EGit, Eclipse, and more that I didn't share
I'll have a look if that works. If not, I'll provide another reproducer MR to see what can be done about this |
I'm only aware of xtext generating such problematic update site. Tycho uses a lot of orbit and eclipse updatesites in the integration tests and we don't see any issues there. |
|
I have checked a larger build now and it seems for some reason now it tries to resolve all dependencies, that's why you see a lot of warnings fro other repos as well ... I'll need to investigate this and hopefully fix that soon. |
And just for completeness, yes sadly most eclipse project supply wrong data as they claim to contain SNAPSHOT maven dependencies while they are really released artifacts :-( We have a guard against that kind and it seems I need to check this guard first before really checking if it should be validated... |
|
The fix is now here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2625
FYI @tivervac