Fix QG4 findings #53
Fix QG4 findings #53
Conversation
|
Helm Lint failing because its still missing release version o docker hub with version v1.2.1 but charts are already updated to be according version app and documentation . |
There was a problem hiding this comment.
Hi @fabiodmota,
please split your fixes to the issues in separate PRs next time. Having them all in one PR makes it very hard to relate the single change to the issue that they fix.
Harder to review and harder to trace fixes for others.
The "helm test" workflow is definitely not fixed with only adding the workflow dispatch trigger. If you want to fix it in a separate PR, i'll approve this one and keep the related issue open
| @@ -20,8 +20,8 @@ | |||
| apiVersion: v2 | |||
| name: country-risk | |||
| type: application | |||
| version: 1.1.1 | |||
There was a problem hiding this comment.
Why is there such a huge jump in the umbrella Chart?
This will make it very confusing for users of your Chart. Could you at least explain this in the CHANGELOG.md
There was a problem hiding this comment.
I increased the chart version to 3.0.3 to be consistent with the subCharts. I think I have been failing to upgrade the version of this whenever there is a change in the charts, and now I have set it to align with them. I can put this explanation in the changelog if it makes it more explanatory.
There was a problem hiding this comment.
Yes please do that. Jumping major versions and even skipping one seems odd at first sight
There was a problem hiding this comment.
Please have a close look at the TRG 5.09. It's not only about manually triggering, but also do the helm test (with ct install) and upgrade step. Therefore the workflow_dispatch needs to define some inputs
There was a problem hiding this comment.
Yes, please, I will make the remaining changes in another PR right away.
|
I left #47 open, to address the missing Helm workflow steps |
Description
This PR addresses fixes for QG4 checks
#47
#48
#49
#50
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: