This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
Remove lib with vulnerability and refactor unit test #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiodmota
force-pushed
the
fix/remove_esapi_and_unit_test_fix
branch
from
ae3ec5e to
b274964
Compare
fabiodmota
force-pushed
the
fix/remove_esapi_and_unit_test_fix
branch
from
b274964 to
ed23399
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vulnerability detected in the org.owasp.esapi library, which was only used for logging error responses of unauthorized access.
Since the rest template did not handle these responses, the library for requests in these use cases was switched to webclient.
Refactoring only in unit tests, without the need for functional changes.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: