Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds default scope extractor #973

Merged
merged 2 commits into from
Jan 9, 2024
Merged

feat: adds default scope extractor #973

merged 2 commits into from
Jan 9, 2024

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jan 4, 2024 •
edited
Loading

WHAT

This is a first IATP integration PR which contains:

The default scope extractor, which is the default credentials needed for DSP comunication e.g. MembershipCredential

In order to start testing IATP integration the IatpHttpConsumerPullWithProxyInMemoryTest has been created that
does a PULL scenario transfer with IATP presentation flow.

The first IATP E2E test contains the following components:

  • Two participants (connector) with their own credential service embedded.
  • One remote STS minting the SI token for both participants.

The keys are are generated per participant and the STS and CS service for simplicity they share the same private key.

The Membership credential for now has been created ahead of time and loaded in the CS store for the participants.

For this tests we used did:example as DID method with a custom cached DIdResolver

There is no policy functions yet that works on the credentials yet. Only MembershipCredential (default one) gets shared and validated.

WHY

iatp integration

Closes #961

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 4, 2024
View reviewed changes
...atp/iatp-extensions/src/main/java/org/eclipse/tractusx/edc/iatp/ih/IdentityHubExtension.java Outdated
public class IdentityHubExtension implements ServiceExtension {

private static final String PRIVATE_KEY = """
-----BEGIN EC PRIVATE KEY-----

Check failure

Code scanning / SonarCloud

Cryptographic private keys should not be disclosed

<!--SONAR_ISSUE_KEY:AYzVSQkAHr3n8WlEkZEn-->Make sure this private key gets revoked, changed, and removed from the code. <p>See more on <a href="https://sonarcloud.io/project/issues?id=eclipse-tractusx_tractusx-edc&issues=AYzVSQkAHr3n8WlEkZEn&open=AYzVSQkAHr3n8WlEkZEn&pullRequest=973">SonarCloud</a></p>
@gitguardian GitGuardian
Copy link

gitguardian bot commented Jan 4, 2024 •
edited
Loading

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@wolf4ood wolf4ood force-pushed the feat/961_default_scope_extractor branch 8 times, most recently from 5e20a32 to f08e1b1 Compare January 8, 2024 10:25
@wolf4ood wolf4ood marked this pull request as ready for review January 8, 2024 10:42
@wolf4ood wolf4ood force-pushed the feat/961_default_scope_extractor branch from f08e1b1 to afb2f93 Compare January 8, 2024 10:51
@wolf4ood wolf4ood force-pushed the feat/961_default_scope_extractor branch from 13e1142 to 13643ca Compare January 9, 2024 08:35
@wolf4ood wolf4ood force-pushed the feat/961_default_scope_extractor branch from 13643ca to d878587 Compare January 9, 2024 08:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wolf4ood wolf4ood merged commit d7adb17 into eclipse-tractusx:main Jan 9, 2024
25 checks passed
@wolf4ood wolf4ood deleted the feat/961_default_scope_extractor branch January 9, 2024 10:58
arnoweiss pushed a commit to arnoweiss/tractusx-edc that referenced this pull request Jan 19, 2024
@wolf4ood @arnoweiss
feat: adds default scope extractor (eclipse-tractusx#973)
bfdfe7e 
* feat: add default scope extractor + E2E test with iatp EDC components

* pr suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@ndr-brt ndr-brt Awaiting requested review from ndr-brt

@jimmarino jimmarino Awaiting requested review from jimmarino

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IATP: default scope extractor
2 participants
@wolf4ood @paullatzelsperger