-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): Remove deprecated/separate validation endpoint #937
fix(helm): Remove deprecated/separate validation endpoint #937
Conversation
This pull request is stale because it has been open for 7 days with no activity. |
This pull request was closed because it has been inactive for 7 days since being marked as stale. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
WHAT
The validation endpoint is not separate anymore and instead part of the /control endpoint.
This PR removes all references to a separate /validation endpoint and instead uses the /control endpoint.
Also updates any references to the validation port in the docs.
WHY
The memory chart currently doesn't work, as the WEB_HTTP_VALIDATION_PORT is not functional and returns a 404.
FURTHER NOTES
There is a clunky workaround, by setting additional environment variables and changing the validation endpoint path and port:
But this causes issues, when deployed via argoCD, as the duplicate Env vars cause proplems during the diff phase.
Closes #909