Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Remove deprecated/separate validation endpoint #937

Merged

Conversation

KilianHaag
Copy link
Contributor

WHAT

The validation endpoint is not separate anymore and instead part of the /control endpoint.
This PR removes all references to a separate /validation endpoint and instead uses the /control endpoint.
Also updates any references to the validation port in the docs.

WHY

The memory chart currently doesn't work, as the WEB_HTTP_VALIDATION_PORT is not functional and returns a 404.

FURTHER NOTES

There is a clunky workaround, by setting additional environment variables and changing the validation endpoint path and port:

  runtime:
    endpoints:
      validation:
        path: /foobar
        port: 8092
    env:
      WEB_HTTP_VALIDATION_PATH: '/foobar'
      WEB_HTTP_VALIDATION_PORT: '8091'
      EDC_DATAPLANE_TOKEN_VALIDATION_ENDPOINT: http://***-runtime:8083/control/token

But this causes issues, when deployed via argoCD, as the duplicate Env vars cause proplems during the diff phase.

Closes #909

Copy link
Contributor

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Dec 23, 2023
Copy link
Contributor

This pull request was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Dec 30, 2023
@ndr-brt ndr-brt reopened this Jan 8, 2024
@ndr-brt ndr-brt added refactoring Refactoring, does not add functionality and removed stale labels Jan 8, 2024
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ndr-brt ndr-brt merged commit eb3bbd9 into eclipse-tractusx:main Jan 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring, does not add functionality
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Deprecated validation endpoint
4 participants