Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: increase EDR token validity #928

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Dec 11, 2023

WHAT

Increase EDR token validity to 30 days

WHY

Lowering down the number of transfer process for data transfers

Closes #927

@wolf4ood wolf4ood force-pushed the feat/927_increase_default_token_validity branch from 729cc4b to e7a3c26 Compare December 11, 2023 11:16
@wolf4ood wolf4ood marked this pull request as ready for review December 11, 2023 11:28
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't we talk about increasing it to a month?

@wolf4ood
Copy link
Contributor Author

Ah right, let me change it

@wolf4ood wolf4ood force-pushed the feat/927_increase_default_token_validity branch from e7a3c26 to 99abeb2 Compare December 11, 2023 13:40
@wolf4ood wolf4ood force-pushed the feat/927_increase_default_token_validity branch from 99abeb2 to ad29fa2 Compare December 11, 2023 14:35
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wolf4ood wolf4ood merged commit c734d09 into eclipse-tractusx:main Dec 12, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Increase token validity for Consumer Pull scenario
3 participants