Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add removed setting from publish workflow #822

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ndr-brt
Copy link
Contributor

@ndr-brt ndr-brt commented Oct 11, 2023

WHAT

the secrets: inherit was removed for some reasons in c8dd495#diff-e81e13daadd1745de51d8b8d85fce1fcd9be355732b64d60a6b56e18c28388caL140

but as mentioned by the EF help desk, that setting is necessary:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3773#note_1223226

WHY

fix publish to swaggerhub

FURTHER NOTES

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Closes # <-- insert Issue number if one exists

@ndr-brt ndr-brt requested review from wolf4ood and bcronin90 October 11, 2023 14:04
@ndr-brt ndr-brt added the bug Something isn't working label Oct 11, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wolf4ood wolf4ood merged commit 5a7ff10 into eclipse-tractusx:main Oct 12, 2023
@ndr-brt ndr-brt deleted the add-removed-setting branch October 12, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants