feat(SqlEdrStore): add configurable vault path #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awellnitz-materna
approved these changes
Oct 2, 2023
|
the basic functionality is there, I'm adding some tests on our end for the CI and it should be ready for review. If you configure the folder when it's released and move/copy them on the new folder they should be valid We do not store the vault path on our end. So the resolved secret will be |
wolf4ood
force-pushed
the
feat/800_vault_path
branch
from
639bf84 to
842d7a3
Compare
paullatzelsperger
approved these changes
Oct 2, 2023
wolf4ood
force-pushed
the
feat/800_vault_path
branch
from
c092422 to
14c1a12
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Add the ability to configure a path in the vault for storing the EDRs
WHY
Flexibility
FURTHER NOTES
Closes #800