Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: centralize edc version #752

Merged
merged 1 commit into from
Sep 6, 2023
Merged

refactor: centralize edc version #752

merged 1 commit into from
Sep 6, 2023

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Sep 5, 2023 •
edited
Loading

WHAT

removes

val annotationProcessorVersion: String by project
val metaModelVersion: String by project
val edcGradlePluginsVersion: String by project

and the version from gradle.properties by using the centralized version in the catalog

WHY

refactoring

Closes #753

@wolf4ood wolf4ood self-assigned this Sep 5, 2023
@wolf4ood wolf4ood added the refactoring Refactoring, does not add functionality label Sep 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wolf4ood wolf4ood marked this pull request as ready for review September 6, 2023 06:19
paullatzelsperger
paullatzelsperger approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know this worked - neat!

@wolf4ood wolf4ood merged commit c45c6aa into eclipse-tractusx:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@ndr-brt ndr-brt ndr-brt approved these changes

Assignees

@wolf4ood wolf4ood

Labels
refactoring Refactoring, does not add functionality
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centralize edc version
3 participants
@wolf4ood @ndr-brt @paullatzelsperger