Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(CPA): obliviates the control plane adapter term and module refactor #606

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jul 12, 2023

WHAT

Refactor module:

  • merge controplane-adapter-spi and edr-cache-spi in one module edr-spi
  • create edr-callback-spi with callbacks related stuff from controlplane-adapter-spi
  • rename controlplane-adapter-api to edr-api
  • rename controlplane-adapter-callback to edr-callback
  • create edr-core with EdrServiceImpl
  • move all edr extensions under edc-extensions:edr

WHY

cleanup

FURTHER NOTES

Also in this PR:

  • added more testing on the ConsumerAssetRequestController
  • added providerId in EndpointDataReferenceEntry
  • added API for deleting cached EDR entry

Closes #605

@wolf4ood wolf4ood force-pushed the feat/605_cpa_modules_refactor branch 5 times, most recently from cc15393 to a720cb9 Compare July 12, 2023 14:50
@wolf4ood wolf4ood force-pushed the feat/605_cpa_modules_refactor branch from a720cb9 to 2d7e07e Compare July 12, 2023 14:59
@wolf4ood wolf4ood marked this pull request as ready for review July 12, 2023 15:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wolf4ood wolf4ood merged commit fd48ba6 into eclipse-tractusx:main Jul 13, 2023
@wolf4ood wolf4ood deleted the feat/605_cpa_modules_refactor branch July 13, 2023 06:45
@wolf4ood wolf4ood restored the feat/605_cpa_modules_refactor branch July 17, 2023 11:52
@wolf4ood wolf4ood deleted the feat/605_cpa_modules_refactor branch July 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

controlplane-adapter-* modules refactor
3 participants