fix(test): converted some MockWebServer to long-running instances #588
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
this PR attempts to fix some of the flaky e2e tests we saw in the past.
The problem there was that the
MockWebServer
could not be started, due to an "Address already in use" error.We don't exactly know where this is coming from, so this is really more of an "exploratory" PR
It should be noted that this goes somewhat against the recommended use of the
MockWebServer
, which requires it to be re-instantiated on every test.WHY
Flaky e2e tests
FURTHER NOTES
other solution ideas are
RetryPolicy
to the instantiation and starting of the mock webserver: this would guard against transient errors such as timing issuesCloses # <-- insert Issue number if one exists