fix(helm charts): Replace all "ids" occurrences in helm charts #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianrusch-zf
changed the title
florianrusch-zf
changed the title
florianrusch-zf
requested review from
paullatzelsperger,
tuncaytunc-zf and
saschaisele-zf
|
it seems the tests didn't run, because the change surface is confined to the // run-all-tests.yml
pull_request:
paths-ignore:
- 'charts/**'could you remove the |
tuncaytunc-zf
approved these changes
Jul 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
@paullatzelsperger done |
paullatzelsperger
approved these changes
Jul 13, 2023
saschaisele-zf
approved these changes
Jul 13, 2023
wolf4ood
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Within the helm charts there are some places, that still refer to the old "ids" protocol
WHY
IDS was replaced with DSP in the past
FURTHER NOTES
controlplane.url.protocolis already taken into consideration when generating the environment variables for the controlplane.