Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update DEPENDENCIES, add check to CI #566

Merged
merged 4 commits into from
Jul 5, 2023
Merged

feat: update DEPENDENCIES, add check to CI #566

merged 4 commits into from
Jul 5, 2023

Conversation

paullatzelsperger
Copy link
Contributor

@paullatzelsperger paullatzelsperger commented Jul 5, 2023 •
edited
Loading

WHAT

Updates the DEPENDENCIES file, adds a check to the CI that verifies the DEPENDENCIES file is up-to-date

WHY

compliance with Eclipse

FURTHER NOTES

Closes # <-- insert Issue number if one exists

@paullatzelsperger paullatzelsperger added bug Something isn't working documentation Improvements or additions to documentation gh-actions labels Jul 5, 2023
@paullatzelsperger paullatzelsperger changed the title chore: update DEPENDENCIES, add check to CI feat: update DEPENDENCIES, add check to CI Jul 5, 2023
@paullatzelsperger paullatzelsperger force-pushed the chore/add_check_for_dependencies_file branch from 84999a0 to 55523e7 Compare July 5, 2023 13:51
AngelikaWittek
AngelikaWittek reviewed Jul 5, 2023
View reviewed changes
Copy link

@AngelikaWittek AngelikaWittek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recomment to grep over the new dep file for the search-string "rejected" in the status column. A rejected lib means you are not allowed to use it.

@paullatzelsperger
Copy link
Contributor Author

I would recomment to grep over the new dep file for the search-string "rejected" in the status column. A rejected lib means you are not allowed to use it.

that is a good idea, thanks. in that case we could let the job fail.

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@paullatzelsperger
Copy link
Contributor Author

Just to demonstrate how this will look like:
image

@Siegfriedk
Copy link
Contributor

Nice. can you show this in the office hour too? I think we are also planing something very simimliar

@paullatzelsperger
Copy link
Contributor Author

Nice. can you show this in the office hour too? I think we are also planing something very simimliar

I had already talked with @SebastianBezold about it. I can definitely share this, but unfortunately i won't be able to make it to the Office Hour on Friday July 7, 2023. Feel free to show it, or I can send out an email to the mailing list.

@paullatzelsperger paullatzelsperger merged commit d31eebe into eclipse-tractusx:main Jul 5, 2023
@Siegfriedk
Copy link
Contributor

@paullatzelsperger no worries, there is another Office Hour next Week on the 14th Of July :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuncaytunc-zf tuncaytunc-zf tuncaytunc-zf approved these changes

@wolf4ood wolf4ood wolf4ood approved these changes

@stefan-ettl stefan-ettl Awaiting requested review from stefan-ettl

@florianrusch-zf florianrusch-zf Awaiting requested review from florianrusch-zf

@AngelikaWittek AngelikaWittek Awaiting requested review from AngelikaWittek

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation gh-actions
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paullatzelsperger @Siegfriedk @wolf4ood @AngelikaWittek @tuncaytunc-zf