Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(charts): add temporary emptyDir volume to the controlplane charts #564

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(charts): add temporary emptyDir volume to the controlplane charts #564

merged 1 commit into from
Jul 5, 2023

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jul 5, 2023 •
edited
Loading

WHAT

It turned out that this #556 was caused by the default security context that prevented the JSON-LD extensions to properly load the cached context from disks.

Logs:

WARNING  Failed to register cached json-ld document: Cannot read resource document/credential-v1.jsonld: 
WARNING  Failed to register cached json-ld document: Cannot read resource document/summary-vc-context-v1.jsonld: 
WARNING  Failed to register cached json-ld document: Cannot read resource document/summary-vc-context-v1.jsonld:

This can be fixed by allowing the setting the property in the securityContext readOnlyRootFilesystem:false so that the process can write in the /tmp directory. With this PR it will not be needed anymore since in all charts a temporary volume will be mounted for /tmp that will be writable.

A proper fix that avoids the temporary volume could be done in EDC upstream by not requiring a File for cached context

@wolf4ood wolf4ood force-pushed the chore/charts_temp_volume branch 2 times, most recently from 929b5e6 to df5d7b9 Compare July 5, 2023 13:17
@wolf4ood wolf4ood marked this pull request as ready for review July 5, 2023 13:26
@wolf4ood wolf4ood changed the title chore(charts): add temporary emptyDir volume to the controlplane charts fix(charts): add temporary emptyDir volume to the controlplane charts Jul 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wolf4ood wolf4ood merged commit 7d99e4d into eclipse-tractusx:main Jul 5, 2023
@wolf4ood wolf4ood mentioned this pull request Jul 5, 2023
Merged
@wolf4ood wolf4ood deleted the chore/charts_temp_volume branch July 5, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullatzelsperger paullatzelsperger paullatzelsperger approved these changes

@tuncaytunc-zf tuncaytunc-zf Awaiting requested review from tuncaytunc-zf

Assignees
No one assigned
Labels
None yet
Projects
EDC PR Board
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolf4ood @paullatzelsperger