Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SSI): adds E2E test for Catalog request with real MIW #544

Merged

Conversation

wolf4ood
Copy link
Contributor

@wolf4ood wolf4ood commented Jun 28, 2023

WHAT

Adds an E2E test with real MIW running. The test is a single CatalogRequest with one participant asking the catalog to self.

Due to the non-trivial seed of credentials in MIW for now it's ok just to have only this flow.
It will still be tested the real communication with MIW, Keycloak and new policy based on credentials.

The used image for MIW is

ghcr.io/catenax-ng/tx-managed-identity-wallets_miw_service:0.0.1-snapshot.2994d69

WHY

Catching regressions

Closes #543

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@wolf4ood wolf4ood force-pushed the feat/543_miw_integration_test branch 5 times, most recently from cad787f to 56afbea Compare June 28, 2023 13:13
@wolf4ood wolf4ood force-pushed the feat/543_miw_integration_test branch from 56afbea to a803041 Compare June 28, 2023 13:24
@wolf4ood wolf4ood marked this pull request as ready for review June 28, 2023 14:09
@wolf4ood
Copy link
Contributor Author

/cc @jimmarino

Copy link
Contributor

@tuncaytunc-zf tuncaytunc-zf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could successfully test it against the MIW

@paullatzelsperger
Copy link
Contributor

KICS is reporting a myriad of problems/warnings. since this is just used for testing, I think we can safely disregard and ignore them. Also, this solution will only stay in place for one release of C-X.

@wolf4ood
Copy link
Contributor Author

Yeah i saw all the warning but since it's only for testing we can ignore them i guess

@Retention(RetentionPolicy.RUNTIME)
@IntegrationTest
@Tag("MiwIntegrationTest")
public @interface MiwIntegrationTest {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc?

Copy link
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing much to add beyond what's already stated :)

.github/workflows/verify.yaml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ports:
- "5432:5432"

wallet:

Check warning

Code scanning / KICS

Memory Not Limited

'deploy' is not defined
ports:
- "5432:5432"

wallet:

Check warning

Code scanning / KICS

Networks Not Set

There is no network declared for the service 'wallet'
ports:
- "5432:5432"

wallet:

Check warning

Code scanning / KICS

Security Opt Not Set

Docker compose file does not have 'security_opt' attribute
driver: local

services:
postgres:

Check notice

Code scanning / KICS

Container Capabilities Unrestricted

Docker compose file doesn't have 'cap_drop' attribute. Make sure your container only has necessary capabilities.
entrypoint: ["java","-jar", "miw-latest.jar", "--spring.security.oauth2.resourceserver.jwt.issuer-uri=http://localhost:8081/realms/miw_test"]
depends_on: [ postgres , keycloak ]

keycloak:

Check notice

Code scanning / KICS

Container Capabilities Unrestricted

Docker compose file doesn't have 'cap_drop' attribute. Make sure your container only has necessary capabilities.
ports:
- "5432:5432"

wallet:

Check notice

Code scanning / KICS

Container Capabilities Unrestricted

Docker compose file doesn't have 'cap_drop' attribute. Make sure your container only has necessary capabilities.
entrypoint: ["java","-jar", "miw-latest.jar", "--spring.security.oauth2.resourceserver.jwt.issuer-uri=http://localhost:8081/realms/miw_test"]
depends_on: [ postgres , keycloak ]

keycloak:

Check notice

Code scanning / KICS

Cpus Not Limited

'deploy' is not defined
driver: local

services:
postgres:

Check notice

Code scanning / KICS

Cpus Not Limited

'deploy' is not defined
ports:
- "5432:5432"

wallet:

Check notice

Code scanning / KICS

Cpus Not Limited

'deploy' is not defined
@paullatzelsperger paullatzelsperger merged commit fb0716b into eclipse-tractusx:main Jun 29, 2023
@wolf4ood wolf4ood deleted the feat/543_miw_integration_test branch July 17, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

MIW E2E integration test
5 participants