-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SSI): adds E2E test for Catalog request with real MIW #544
feat(SSI): adds E2E test for Catalog request with real MIW #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KICS found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
cad787f
to
56afbea
Compare
56afbea
to
a803041
Compare
/cc @jimmarino |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could successfully test it against the MIW
KICS is reporting a myriad of problems/warnings. since this is just used for testing, I think we can safely disregard and ignore them. Also, this solution will only stay in place for one release of C-X. |
Yeah i saw all the warning but since it's only for testing we can ignore them i guess |
...edential-client/src/main/java/org/eclipse/tractusx/edc/iam/ssi/miw/api/MiwApiClientImpl.java
Outdated
Show resolved
Hide resolved
@Retention(RetentionPolicy.RUNTIME) | ||
@IntegrationTest | ||
@Tag("MiwIntegrationTest") | ||
public @interface MiwIntegrationTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc?
edc-tests/e2e-tests/src/test/java/org/eclipse/tractusx/edc/tests/catalog/MiwSsiCatalogTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing much to add beyond what's already stated :)
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
ports: | ||
- "5432:5432" | ||
|
||
wallet: |
Check warning
Code scanning / KICS
Memory Not Limited
ports: | ||
- "5432:5432" | ||
|
||
wallet: |
Check warning
Code scanning / KICS
Networks Not Set
ports: | ||
- "5432:5432" | ||
|
||
wallet: |
Check warning
Code scanning / KICS
Security Opt Not Set
driver: local | ||
|
||
services: | ||
postgres: |
Check notice
Code scanning / KICS
Container Capabilities Unrestricted
entrypoint: ["java","-jar", "miw-latest.jar", "--spring.security.oauth2.resourceserver.jwt.issuer-uri=http://localhost:8081/realms/miw_test"] | ||
depends_on: [ postgres , keycloak ] | ||
|
||
keycloak: |
Check notice
Code scanning / KICS
Container Capabilities Unrestricted
ports: | ||
- "5432:5432" | ||
|
||
wallet: |
Check notice
Code scanning / KICS
Container Capabilities Unrestricted
entrypoint: ["java","-jar", "miw-latest.jar", "--spring.security.oauth2.resourceserver.jwt.issuer-uri=http://localhost:8081/realms/miw_test"] | ||
depends_on: [ postgres , keycloak ] | ||
|
||
keycloak: |
Check notice
Code scanning / KICS
Cpus Not Limited
driver: local | ||
|
||
services: | ||
postgres: |
Check notice
Code scanning / KICS
Cpus Not Limited
ports: | ||
- "5432:5432" | ||
|
||
wallet: |
Check notice
Code scanning / KICS
Cpus Not Limited
WHAT
Adds an E2E test with real MIW running. The test is a single
CatalogRequest
with one participant asking the catalog to self.Due to the non-trivial seed of credentials in MIW for now it's ok just to have only this flow.
It will still be tested the real communication with MIW, Keycloak and new policy based on credentials.
The used image for MIW is
WHY
Catching regressions
Closes #543