-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release version 0.3.4 #367
Conversation
…g java application
…iles docs: Lint all *.md files and replace product-edc with tractusx-edc
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
feat(baseImage): replace alpine with temurin as base image for running java applications
…l_info docs: add additional info for running business tests locally
feat: Add markdown linter
chore: upstream some minor fixes necessary for creating releases
Bumps alpine from 3.17.3 to 3.18.0. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore(build): use composite action for GPG import * Update .github/actions/import-gpg-key/action.yml Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]> --------- Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
* feat: add Helm chart that utilized Azure KeyVault + Postgres * pr remarks * Update charts/tractusx-connector-azure-vault/README.md.gotmpl Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]> * use cUrl instead of wget do satisfy SonarCloud --------- Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
In the controlplane deploment a required value was misspelled. Signed-off-by: Marco Lecheler <[email protected]>
Bumps [org.testcontainers:vault](https://github.com/testcontainers/testcontainers-java) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.18.0...1.18.1) --- updated-dependencies: - dependency-name: org.testcontainers:vault dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8.1 (#340) Bumps [org.testcontainers:junit-jupiter](https://github.com/testcontainers/testcontainers-java) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.18.0...1.18.1) --- updated-dependencies: - dependency-name: org.testcontainers:junit-jupiter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…342) * feat: replace using hard-coded certs with dynamically generated ones * added az login * set AZ KeyVault secrets before deploy test * allow no sub * escape command * avoid logging of sensitive info
Bumps [org.flywaydb:flyway-core](https://github.com/flyway/flyway) from 9.17.0 to 9.18.0. - [Release notes](https://github.com/flyway/flyway/releases) - [Commits](flyway/flyway@flyway-9.17.0...flyway-9.18.0) --- updated-dependencies: - dependency-name: org.flywaydb:flyway-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add migration for transferprocess_properties default value Signed-off-by: Brendan Cronin <[email protected]> * Update edc-extensions/postgresql-migration/src/main/resources/org/eclipse/tractusx/edc/postgresql/migration/transferprocess/V0_0_6__Snapshot_20230109_Update.sql Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]> * Move to new migration file Signed-off-by: Brendan Cronin <[email protected]> * Copy+Paste=Bad Signed-off-by: Brendan Cronin <[email protected]> * Empty commit * Update edc-extensions/postgresql-migration/src/main/resources/org/eclipse/tractusx/edc/postgresql/migration/transferprocess/V0_0_7__Default_Value_For_Properties.sql --------- Signed-off-by: Brendan Cronin <[email protected]> Co-authored-by: Florian Rusch (ZF Friedrichshafen AG) <[email protected]>
* Rename ingress endpoint from ids to protocol * Rename ingress endpoint from ids to protocol * fix service-runtime * fix renaming issues
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
3710286 | Generic Private Key | d48d22b | edc-tests/deployment/src/main/resources/helm/test-infrastructure/values.yaml | View secret |
3710286 | Generic Private Key | d48d22b | edc-tests/deployment/src/main/resources/helm/test-infrastructure/values.yaml | View secret |
6673077 | Generic Private Key | d48d22b | .github/workflows/deploy-test-secrets | View secret |
6673077 | Generic Private Key | d48d22b | .github/workflows/deploy-test-secrets | View secret |
6483013 | Generic Private Key | fcb4694 | .github/workflows/deploy-test-secrets | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
skipped GitGuardian, as it still reports the (already-deleted) secrets as violation. We would have to rewrite the git history, which would potentially cause problems when merging back to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes are already at Tractus-X EDC! This big PR is just because of the specific Release built we're doing via a Pull-Request.
Opened an IP Issue check on Eclipse side to to 1. the size of the PR & because not every contributor on that PR is a committer. https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/8463 @AngelikaWittek FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog and (c) please revisit, for the other comments please make a note and adress them today/next release
docs/development/decision-records/2023-04-03_renaming_branches/README.md
Outdated
Show resolved
Hide resolved
|
||
The ConnectorKit provides a connector framework, based on the [Eclipse Dataspace Connector][edc-url] for sovereign, cross-enterprise data exchange. | ||
|
||
![EDC Overview](images/edc_overview.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your images should be editable somehow. Please be aware that there is currently an ongoing discusiion on aligning diagram drawing tool and were to put the original file.
|
||
To facilitate deployment of these different builds and their prerequisites, | ||
Helm charts are provided. The charts and their documentation can be found | ||
[here](https://github.com/eclipse-tractusx/tractusx-edc/blob/main/charts/README.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to pin this with the release in the long term. Especially when we versioning our docs
@@ -0,0 +1,35 @@ | |||
/* | |||
* Copyright (c) 2023 Bayerische Motoren Werke Aktiengesellschaft (BMW AG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks wrong. Shouldn't that be aligned with the other headers?
edc-tests/cucumber/src/test/java/org/eclipse/tractusx/edc/tests/data/S3DataAddress.java
Show resolved
Hide resolved
@@ -0,0 +1,25 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(c)
ec1c8be
to
16ab8c5
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR was created in response to a manual trigger of the release workflow.
The changelog was updated and versions have been bumped in commit d96f5a5e2d825aca4d21a8f1aa33000a8b8ab145.
Merging this PR will create a GitHub release and upload any assets that are created as part of the release build.