Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add license and copyright header to the charts #285

Conversation

tuncaytunc-zf
Copy link
Contributor

WHAT

Add license and copyright header to the charts

WHY

License and copyright header were missing on charts

FURTHER NOTES

Closes #284

@tuncaytunc-zf tuncaytunc-zf added the documentation Improvements or additions to documentation label Apr 25, 2023
@SebastianBezold
Copy link
Contributor

LGTM, are there issues with the business tests, or are they just flaky @tuncaytunc-zf?

@gitguardian
Copy link

gitguardian bot commented Apr 26, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6481709 Generic Private Key e545d92 edc-tests/cucumber/src/main/resources/deployment/helm/supporting-infrastructure/values.yaml View secret
6481710 Generic Private Key e545d92 edc-tests/cucumber/src/main/resources/deployment/helm/supporting-infrastructure/values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tuncaytunc-zf
Copy link
Contributor Author

LGTM, are there issues with the business tests, or are they just flaky @tuncaytunc-zf?

Indeed there was an issue with business-tests, the certificates we are using for tests were expired, I have recreated them, the tests are running now but GitGuardian is complaining now we could ignore it as the secrets were already there but just expired :-)

@paullatzelsperger
Copy link
Contributor

paullatzelsperger commented Apr 26, 2023

Indeed there was an issue with business-tests, the certificates we are using for tests were expired, I have recreated them, the tests are running now but GitGuardian is complaining now we could ignore it as the secrets were already there but just expired :-)

@SebastianBezold @tuncaytunc-zf There is issue #278 where we need to delete hard-coded keys from our code base. Once we generate the certs/keys "on-the-fly" we should never have this problem again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Chart templates of 0.3.3 tag miss license and copyright header
3 participants