-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add license and copyright header to the charts #285
chore: Add license and copyright header to the charts #285
Conversation
LGTM, are there issues with the business tests, or are they just flaky @tuncaytunc-zf? |
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
6481709 | Generic Private Key | e545d92 | edc-tests/cucumber/src/main/resources/deployment/helm/supporting-infrastructure/values.yaml | View secret |
6481710 | Generic Private Key | e545d92 | edc-tests/cucumber/src/main/resources/deployment/helm/supporting-infrastructure/values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Indeed there was an issue with business-tests, the certificates we are using for tests were expired, I have recreated them, the tests are running now but GitGuardian is complaining now we could ignore it as the secrets were already there but just expired :-) |
@SebastianBezold @tuncaytunc-zf There is issue #278 where we need to delete hard-coded keys from our code base. Once we generate the certs/keys "on-the-fly" we should never have this problem again. |
WHAT
Add license and copyright header to the charts
WHY
License and copyright header were missing on charts
FURTHER NOTES
Closes #284